-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowed usage of multi_model_statistics
on single cubes/products
#1849
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1849 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 232 232
Lines 11555 11557 +2
=======================================
+ Hits 10591 10593 +2
Misses 964 964
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Open question for the @ESMValGroup/esmvaltool-coreteam: In the current state of the PR, using This definitely makes sense, but one could also argue that the result should be an array with zeros here (see #1211). How should we deal with this? Iris allows using |
Are there more iris analysis operators that support arguments? If yes, it might be nice to add support for that in the multimodel statistics function. Maybe best done in a separate pull request? |
Yeah, lots of operators support arguments, see https://scitools-iris.readthedocs.io/en/latest/generated/api/iris/analysis.html. Examples are I opened an issue here: #1851 |
This is ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, cheers @schlunma 🍺
Description
This PR allows the usage of our
multi_model_statistics
andensemble_statistics
preprocessors on single cubes/products.Closes #1211
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: