Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve codecov status checks #1195

Merged
merged 3 commits into from
Jun 29, 2021
Merged

Improve codecov status checks #1195

merged 3 commits into from
Jun 29, 2021

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jun 26, 2021

Description

Improve codecov status checks

Link to documentation: https://docs.codecov.com/docs/commit-status


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela changed the title Create codecov.yml Improve codecov status checks Jun 26, 2021
@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #1195 (91a9336) into main (f24575b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1195   +/-   ##
=======================================
  Coverage   85.51%   85.51%           
=======================================
  Files         188      188           
  Lines        9147     9147           
=======================================
  Hits         7822     7822           
  Misses       1325     1325           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24575b...91a9336. Read the comment docs.

@bouweandela bouweandela marked this pull request as ready for review June 26, 2021 09:36
@schlunma
Copy link
Contributor

Is there an easy way to test this? Or could we merge this into #1194 and see if it let's the tests pass?

@bouweandela
Copy link
Member Author

bouweandela commented Jun 28, 2021

That seems to be the easiest solution, because then we can see if it works for you

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests do not fail in #1194 anymore with this 🎉

@schlunma schlunma merged commit 3b653c4 into main Jun 29, 2021
@schlunma schlunma deleted the codecov-config branch June 29, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants