Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove write_netcdf and write_plots from config-user.yml #1300

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Sep 1, 2021

Description

Remove write_netcdf and write_plots from config-user.yml. These settings have been deprecated for a year and are scheduled for removal in v2.4.

Related to #93


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added this to the v2.4.0 milestone Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1300 (5c7bdbd) into main (d4667eb) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
+ Coverage   86.45%   86.66%   +0.21%     
==========================================
  Files         188      188              
  Lines        9193     9182      -11     
==========================================
+ Hits         7948     7958      +10     
+ Misses       1245     1224      -21     
Impacted Files Coverage Δ
esmvalcore/_recipe.py 91.34% <ø> (-0.04%) ⬇️
esmvalcore/_task.py 62.32% <ø> (+0.43%) ⬆️
...mvalcore/experimental/config/_config_validators.py 91.73% <ø> (ø)
esmvalcore/_config/_config.py 94.11% <100.00%> (+5.40%) ⬆️
esmvalcore/experimental/config/_config_object.py 89.07% <0.00%> (+9.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4667eb...5c7bdbd. Read the comment docs.

@bouweandela
Copy link
Member Author

The issue reported by Codacy is best solved by integrating the esmvalcore.experimental.config module into the main tool, but that is out of scope for this pull request.

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! I ran the test recipe successfully and also tested using an invalid configuration option, which gives an

esmvalcore.experimental.config._validated_config.InvalidConfigParameter: `write_plots` is not a valid config parameter.

now. Nice work 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants