Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog and update version number for v2.10.0rc1 #2249

Merged
merged 8 commits into from
Nov 1, 2023
Merged

Conversation

zklaus
Copy link

@zklaus zklaus commented Oct 31, 2023

Description

Update release version and add changelog for the upcoming v2.10.0 release.

Link to documentation: https://esmvaltool--2249.org.readthedocs.build/projects/ESMValCore/en/2249/changelog.html#v2-10-0


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #2249 (da027be) into main (56cc385) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2249   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files         238      238           
  Lines       12932    12932           
=======================================
  Hits        12088    12088           
  Misses        844      844           

@valeriupredoi
Copy link
Contributor

yay 🥳 🎈

@zklaus zklaus added the documentation Improvements or additions to documentation label Oct 31, 2023
@zklaus zklaus changed the title Prepare v2.10.0rc1 Add changelog and update version number for v2.10.0rc1 Oct 31, 2023
@zklaus zklaus marked this pull request as ready for review October 31, 2023 15:32
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! One minor comment from me 🍺

doc/changelog.rst Outdated Show resolved Hide resolved
@zklaus
Copy link
Author

zklaus commented Nov 1, 2023

Updated branch with new draft-release-notes helper script.

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice already, but it could use some improvement in how the entries are grouped.

doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
@valeriupredoi
Copy link
Contributor

gotta give it to you two for being so attentive wrt Changelog - I've seen a lot of packages (big ones, not itty bitty ones) that don't even include one, and just point the user to some rando hash lists 🎖️ 🍻

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for re-ordering, looks much better now! Just a few more suggestions on improving the formatting.

doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
@zklaus zklaus merged commit 444cdbf into main Nov 1, 2023
3 checks passed
@zklaus zklaus deleted the release-prep branch November 1, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants