Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More lazy fixes and preprocessing functions #2325

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Feb 6, 2024

Description

Various small improvements in lazy data computations by using coordinate methods has_bounds(), core_points(), core_bounds() where possible.

Related to #674 and #42


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela mentioned this pull request Feb 6, 2024
62 tasks
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f30fa6) 93.82% compared to head (9bad950) 93.97%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2325      +/-   ##
==========================================
+ Coverage   93.82%   93.97%   +0.15%     
==========================================
  Files         240      240              
  Lines       13289    13273      -16     
==========================================
+ Hits        12468    12473       +5     
+ Misses        821      800      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela marked this pull request as ready for review February 7, 2024 08:52
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bouwe, LGTM! Just some minor comments from my side.

esmvalcore/cmor/_fixes/cmip5/hadgem2_cc.py Outdated Show resolved Hide resolved
esmvalcore/preprocessor/_units.py Outdated Show resolved Hide resolved
@valeriupredoi valeriupredoi added enhancement New feature or request preprocessor Related to the preprocessor dask related to improvements using Dask labels Feb 15, 2024
@valeriupredoi
Copy link
Contributor

brill work, fellas 🍻

@valeriupredoi valeriupredoi merged commit 3f610e7 into main Feb 15, 2024
4 checks passed
@valeriupredoi valeriupredoi deleted the more-lazy-fixes-and-preprocs branch February 15, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask related to improvements using Dask enhancement New feature or request preprocessor Related to the preprocessor
Projects
Development

Successfully merging this pull request may close these issues.

3 participants