Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ICON fixes for hfls and hfss #2360

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Added ICON fixes for hfls and hfss #2360

merged 4 commits into from
Mar 5, 2024

Conversation

diegokam
Copy link
Contributor

@diegokam diegokam commented Mar 5, 2024

Description

This pull request adds support for variables hfls and hfss for ICON.
For these variables it is necessary to change the sign of the input data.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@diegokam diegokam added the fix for dataset Related to dataset-specific fix files label Mar 5, 2024
@diegokam diegokam added this to the v2.11.0 milestone Mar 5, 2024
@diegokam diegokam requested a review from schlunma March 5, 2024 09:59
@diegokam diegokam self-assigned this Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.12%. Comparing base (5941300) to head (f938a53).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2360   +/-   ##
=======================================
  Coverage   94.12%   94.12%           
=======================================
  Files         241      241           
  Lines       13387    13393    +6     
=======================================
+ Hits        12600    12606    +6     
  Misses        787      787           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @diegokam, looks good to me! 🚀

Do you want to add yourself to the list of contributors here and here?

@diegokam
Copy link
Contributor Author

diegokam commented Mar 5, 2024

Thanks @diegokam, looks good to me! 🚀

Do you want to add yourself to the list of contributors here and here?

Sure, I am going to add it! Thanks!

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I successfully tested this with real data.

Merging this now since we need it for a demonstration next week and this only affects ICON data.

@schlunma schlunma merged commit bf04feb into main Mar 5, 2024
5 checks passed
@schlunma schlunma deleted the icon_hfls branch March 5, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants