Pin numpy<2.0.0 to avoid pulling 2.0.0rcX #2415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should pin numpy <2 for the release - David Hassell pulled the rc1 in the cfpython env, here's what I wrote to him this is the bug in pip that makes possible a pre package get pulled in pypa/pip#7579 and real world case for the same issue you had here Unidata/cftime#327 - slim chances for us to hit this bug, since all's been fine so far, but better err on the safe side!
@ehogan @chrisbillowsMO I think it'd be safe to include this in the release, maybe just after ESMValCore rc1, so it doesn't mess with your current procedures. Once numpy=2 stable is out, and we've fixed all the wiggles (ours or not) via #2395 then we can unpin. Cheers 🍺
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: