Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More reliable datasets to recipe conversion #2472

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jul 2, 2024

Description

Make the _to_frozen accept more types of input data to avoid a crash.

Closes #2466


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.61%. Comparing base (495176a) to head (1f1b2aa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2472      +/-   ##
==========================================
- Coverage   94.62%   94.61%   -0.01%     
==========================================
  Files         247      247              
  Lines       14057    14060       +3     
==========================================
+ Hits        13301    13303       +2     
- Misses        756      757       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela marked this pull request as ready for review July 2, 2024 13:10
@bouweandela bouweandela requested a review from schlunma July 2, 2024 13:10
@schlunma
Copy link
Contributor

schlunma commented Jul 2, 2024

I think I know now what's going on in #2466. In summary, datasets from two different rootpaths might have different facets in the input directory DRS which may lead to different types of the facet values.

Unfortunately, this PR does not fix that problem; I am still getting the same errors.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, not sure about its actual utility, in light of Manu's comment, but approving from an engineering point 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing of filled recipe fails with TypeError: '<' not supported between instances of 'str' and 'tuple'
3 participants