Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CFG with configuration options given via command line #2595

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Nov 29, 2024

Description

While testing #2522, I noticed that CFG is not updated with config options given via command line. This PR fixes that.

It would probably be good to unify our usage of Session and CFG in the code base, but that's something for another PR.

Closes #2594


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the bug Something isn't working label Nov 29, 2024
@schlunma schlunma added this to the v2.12.0 milestone Nov 29, 2024
@schlunma schlunma self-assigned this Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (1cf3862) to head (bcc949a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2595   +/-   ##
=======================================
  Coverage   94.66%   94.67%           
=======================================
  Files         251      251           
  Lines       14302    14302           
=======================================
+ Hits        13539    13540    +1     
+ Misses        763      762    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela
Copy link
Member

It would probably be good to unify our usage of Session and CFG in the code base, but that's something for another PR.

Indeed, in many places we're using the global CFG where we should be using Session objects. This seems more relevant for usage from Python/Jupyter notebook, as the command line does not allow running multiple recipes (with different settings) anyway.

@schlunma schlunma merged commit d8ad2f0 into main Nov 29, 2024
7 checks passed
@schlunma schlunma deleted the update_cfg_with_cli_args branch November 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFG is not updated with configuration options given via command line arguments
2 participants