Add on-the-fly CMORizer for ICON-XPP #2659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c742deb)
(cherry picked from commit dc55690)
(cherry picked from commit fec33a1)
… with wrong exceptions flagged by prospector (cherry picked from commit d39fc88)
…onfig (cherry picked from commit a4c9423)
(cherry picked from commit cc9e50d)
(cherry picked from commit ebda3b9)
(cherry picked from commit 2edc268)
(cherry picked from commit 0c3f2ae)
(cherry picked from commit f048a81)
(cherry picked from commit fe3ff7b)
Co-authored-by: Valeriu Predoi <[email protected]> (cherry picked from commit 93cfe33)
(cherry picked from commit 7b0f8cd)
schlunma
commented
Feb 11, 2025
| @@ -519,6 +528,511 @@ def _set_range_in_0_360(lon_coord): | |||
| lon_coord.bounds = (lon_coord.core_bounds() + 360.0) % 360.0 | |||
|
|
|||
|
|
|||
| class AllVarsBase(IconFix): | |||
There was a problem hiding this comment.
This class has been copy-pasted from icon.py without any changes.
schlunma
commented
Feb 11, 2025
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class AllVars(IconFix): |
There was a problem hiding this comment.
This class has been copy-pasted to icon/_base_fixes.py without any changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2659 +/- ##
==========================================
+ Coverage 95.08% 95.09% +0.01%
==========================================
Files 255 256 +1
Lines 14884 14927 +43
==========================================
+ Hits 14152 14195 +43
Misses 732 732 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ICON-XPP (eXtendedPrediction and Projection) is the new version of the ICON model that will be used for the German contribution to CMIP7. It allows performing NWP and climate projections with one single model. The model code is published open-source and can be downloaded from https://www.icon-model.org/.
The basic structure of the model output is very similar to the old ICON version ("ICON-A", based on ECHAM physics), so most of the code from the old on-the-fly CMORizer can be re-used. The main difference between the new and old model output are the variable names, which is tackled in this PR via the extra facets.
Link to documentation: https://esmvaltool--2659.org.readthedocs.build/projects/ESMValCore/en/2659/quickstart/find_data.html#icon
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: