Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options write_plots and write_netcdf will be removed in ESMValCore v2.4 #2005

Closed
bouweandela opened this issue Jan 27, 2021 · 6 comments
Closed

Comments

@bouweandela
Copy link
Member

bouweandela commented Jan 27, 2021

The options in config-user.yml write_plots and write_netcdf are deprecated in ESMValCore v2.2 and will be removed in v2.4. See ESMValGroup/ESMValCore#93 and ESMValGroup/ESMValCore#808 for previous decisions on the topic.

This means that for those diagnostic scripts that support these options, they will have to be moved to the diagnostic script settings in the recipe.

@ESMValGroup/tech-reviewers Please keep this in mind when reviewing new recipes.

@ESMValGroup/esmvaltool-recipe-maintainers Please update your recipes before the ESMValTool v2.4 release (likely somewhere in autumn 2021).

@stefsmeets
Copy link
Contributor

stefsmeets commented Feb 8, 2021

Note that the shared submodule also has instances of cfg['write_netcdf'] / cfg['write_plots'] which will cause the tool to crash with KeyError if these keys are not available in the config-user.yml.

@bouweandela
Copy link
Member Author

Note that the shared submodule also has instances of cfg['write_netcdf'] / cfg['write_plots'] which will cause the tool to crash with KeyError if these keys are not available in the config-user.yml.

That should be fixed by #2018.

@bouweandela
Copy link
Member Author

@ESMValGroup/esmvaltool-recipe-maintainers Please note that this feature will be removed in the upcoming v2.4 release planned for October. Please update your recipes and their documentation if they support the write_netcdf or write_plots setting (or even require it to run successfully).

@bouweandela bouweandela changed the title Options write_plots and write_netcdf are deprecated in ESMValCore v2.2 Options write_plots and write_netcdf will be removed in ESMValCore v2.4 Sep 2, 2021
@axel-lauer
Copy link
Contributor

Just opened a new pull request that removes all instances of "write_plots" and "write_netcdf" from all NCL diagnostics that were still supporting these options: #2331

@valeriupredoi
Copy link
Contributor

cheers @axel-lauer - I can review it techy-wise if you want me to 😁

@axel-lauer
Copy link
Contributor

@valeriupredoi Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants