Removed 'write_plots' from all NCL diagnostics

[axel-lauer]

This pr removes the deprecated feature "write_plots" from all NCL diagnostics that were still using this flag. This pr has been opened in response to issue #2005.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title
• 🛠 Code is written according to the code quality guidelines
• 🛠 Documentation is available
• 🛠 Tests run successfully
• 🛠 The list of authors is up to date
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

• 🧪 Recipe runs successfully
• 🧪 Recipe is well documented
• 🧪 Figure(s) and data look as expected from literature
• 🛠 Provenance information has been added

---

To help with the number of pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[zklaus]

I checked to the best of my abilities. If you, @LisaBock want to review anyways, please do; I will nevertheless go ahead with the merge since this is rather technical.

[zklaus]

Thanks, @axel-lauer for taking care of this! For the future, we generally expect authors to complete the checklist at the top of the PR prior to the review.

[zklaus]

@esmvalbot, please run bock20jgr/recipe_bock20jgr_fig_1-4.yml

[zklaus]

@esmvalbot Please run bock20jgr/recipe_bock20jgr_fig_1-4.yml
@esmvalbot Please run bock20jgr/recipe_bock20jgr_fig_8-10.yml
@esmvalbot Please run recipe_clouds_bias.yml
@esmvalbot Please run recipe_clouds_ipcc.yml
@esmvalbot Please run recipe_collins13ipcc.yml
@esmvalbot Please run recipe_flato13ipcc.yml
@esmvalbot Please run recipe_lauer13jclim.yml
@esmvalbot Please run recipe_seaice.yml

[esmvalbot]

Sorry, ESMValBot can not find bock20jgr/recipe_bock20jgr_fig_1-4.yml
@esmvalbot Please run bock20jgr/recipe_bock20jgr_fig_8-10.yml
@esmvalbot Please run recipe_clouds_bias.yml
@esmvalbot Please run recipe_clouds_ipcc.yml
@esmvalbot Please run recipe_collins13ipcc.yml
@esmvalbot Please run recipe_flato13ipcc.yml
@esmvalbot Please run recipe_lauer13jclim.yml
@esmvalbot Please run recipe_seaice.yml recipe in ESMValGroup/ESMValTool repo at remove_write_netcdf_plots_ncl branch, please check that recipe name is correct

[zklaus]

@esmvalbot Please run bock20jgr/recipe_bock20jgr_fig_1-4.yml

[esmvalbot]

Since @zklaus asked, ESMValBot will run recipe bock20jgr/recipe_bock20jgr_fig_1-4.yml as soon as possible, output will be generated here

[zklaus]

@esmvalbot Please run bock20jgr/recipe_bock20jgr_fig_8-10.yml

[esmvalbot]

Since @zklaus asked, ESMValBot will run recipe bock20jgr/recipe_bock20jgr_fig_8-10.yml as soon as possible, output will be generated here

[zklaus]

@esmvalbot Please run recipe_clouds_bias.yml

[esmvalbot]

Since @zklaus asked, ESMValBot will run recipe recipe_clouds_bias.yml as soon as possible, output will be generated here

[zklaus]

@esmvalbot Please run recipe_clouds_ipcc.yml

[esmvalbot]

Since @zklaus asked, ESMValBot will run recipe recipe_clouds_ipcc.yml as soon as possible, output will be generated here

[zklaus]

@esmvalbot Please run recipe_collins13ipcc.yml

[esmvalbot]

Since @zklaus asked, ESMValBot will run recipe recipe_collins13ipcc.yml as soon as possible, output will be generated here

[zklaus]

@esmvalbot Please run recipe_flato13ipcc.yml

[esmvalbot]

Since @zklaus asked, ESMValBot will run recipe recipe_flato13ipcc.yml as soon as possible, output will be generated here

[zklaus]

@esmvalbot Please run recipe_lauer13jclim.yml

[esmvalbot]

Since @zklaus asked, ESMValBot will run recipe recipe_lauer13jclim.yml as soon as possible, output will be generated here

[zklaus]

@esmvalbot Please run recipe_seaice.yml

[esmvalbot]

Since @zklaus asked, ESMValBot will run recipe recipe_seaice.yml as soon as possible, output will be generated here

[zklaus]

The only failing tests are missing titles in recipes.

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe bock20jgr/recipe_bock20jgr_fig_1-4.yml: exit is 1, output has been generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe bock20jgr/recipe_bock20jgr_fig_8-10.yml: exit is 255, output has been generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_clouds_bias.yml: exit is 255, output has been generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_clouds_ipcc.yml: exit is 255, output has been generated here

[remi-kazeroni]

I'm stopping the runs triggered here because the runtime of these recipes is quite long and makes the bot unavailable for other PRs which need quick runs. I'm happy to restart these runs at the end of the day.

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_collins13ipcc.yml: exit is 1, output has been generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_flato13ipcc.yml: exit is 1, output has been generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_lauer13jclim.yml: exit is 1, output has been generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_seaice.yml: exit is 1, output has been generated here