Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin importlib_metadata <8 #3699

Closed
ehogan opened this issue Jul 1, 2024 · 1 comment · Fixed by #3700
Closed

Pin importlib_metadata <8 #3699

ehogan opened this issue Jul 1, 2024 · 1 comment · Fixed by #3700
Assignees
Milestone

Comments

@ehogan
Copy link
Contributor

ehogan commented Jul 1, 2024

When creating a new environment for testing ESMValCore v2.11.0rc2, the issue I reported at #3208 (comment) was present. @valeriupredoi identified that importlib_metadata was the culprit:

(rc1-env) % conda list importlib_metadata
# packages in environment at /miniforge3/envs/rc1-env:
#
# Name                    Version                   Build  Channel
importlib_metadata        7.1.0                hd8ed1ab_0    conda-forge
(rc2-env) % conda list importlib_metadata
# packages in environment at /miniforge3/envs/rc2-env:
#
# Name                    Version                   Build  Channel
importlib_metadata        8.0.0                hd8ed1ab_0    conda-forge

The solution is to add the importlib_metadata dependency to ESMValTool and pin the version to <8.

Note that importlib_metadata will be removed in ESMValGroup/ESMValCore#2447; the removal should also be added to #3683 after the release / before the release branch is merged into main 👍

@ehogan ehogan added this to the v2.11.0 milestone Jul 1, 2024
@ehogan ehogan self-assigned this Jul 1, 2024
@ehogan ehogan changed the title Pin importlib_metadata <8 Pin importlib_metadata <8 Jul 1, 2024
@ehogan ehogan mentioned this issue Jul 1, 2024
6 tasks
@ehogan ehogan closed this as completed Jul 2, 2024
@valeriupredoi
Copy link
Contributor

just to add to this retroactively - this shouldn't be a problem anymore once esmf/esmpy go past 8.6.0 pin (currently blocked by NCL, and it may be a while until it gets unblocked) - adding info since I introduce the pin in main via #3501 - CC @bouweandela

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants