-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update environment: pin iris>=3.11
, unpin cartopy
and allow for numpy >=2
#3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriupredoi
changed the title
Update environment (unpin
Update environment: unpin Nov 14, 2024
cartopy
and numpy >=2
now allowed)cartopy
and allow for numpy >=2
valeriupredoi
changed the title
Update environment: unpin
Update environment: pin Nov 14, 2024
cartopy
and allow for numpy >=2
iris>=3.11
, unpin cartopy
and allow for numpy >=2
schlunma
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks V, just have a couple of minor comments.
Co-authored-by: Manuel Schlund <[email protected]>
cheers for the review, Manu 🍺 |
schlunma
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
ehogan
added a commit
that referenced
this pull request
Nov 19, 2024
* main: (31 commits) Update environment: pin `iris>=3.11`, unpin `cartopy` and allow for `numpy >=2` (#3811) Fix issue related to removal/change of private function imported in `diag_scripts/shared/_supermeans.py` (deprecation in iris=3.11) (#3810) Remove recipe filler utility (#3777) [Condalock] Update Linux condalock file (#3809) change authors name (#3806) [Condalock] Update Linux condalock file (#3798) Fix contourf plots for masked data (#3797) [Condalock] Update Linux condalock file (#3796) Add next release schedule (#3794) Use `transform_first=True` for contourf plots with Robinson projection to avoid cartopy bug (#3789) Pin pys2index >=0.1.5 in osx environment (#3792) Adding a CMORiser for CMAP data for pr (#3766) Adding pr, tauu, tauv, tos to NCEP2 CMORISer (#3765) Readthedocs configuration/builds: revert to miniconda before miniforge is available (#3785) Adapt ESMValTool to new configuration (#3761) Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER (#3763) update comment in conda lock creation Github action (#3788) [Condalock] Update Linux condalock file (#3786) update Docker builds badge in README (#3783) Pin mamba<2 for conda-lock: solution by Ben Mares @maresb (#3771) ...
ehogan
added a commit
that referenced
this pull request
Nov 19, 2024
…Tool into 3723_remove_rose_cylc * '3723_remove_rose_cylc' of github.com:ESMValGroup/ESMValTool: (31 commits) Update environment: pin `iris>=3.11`, unpin `cartopy` and allow for `numpy >=2` (#3811) Fix issue related to removal/change of private function imported in `diag_scripts/shared/_supermeans.py` (deprecation in iris=3.11) (#3810) Remove recipe filler utility (#3777) [Condalock] Update Linux condalock file (#3809) change authors name (#3806) [Condalock] Update Linux condalock file (#3798) Fix contourf plots for masked data (#3797) [Condalock] Update Linux condalock file (#3796) Add next release schedule (#3794) Use `transform_first=True` for contourf plots with Robinson projection to avoid cartopy bug (#3789) Pin pys2index >=0.1.5 in osx environment (#3792) Adding a CMORiser for CMAP data for pr (#3766) Adding pr, tauu, tauv, tos to NCEP2 CMORISer (#3765) Readthedocs configuration/builds: revert to miniconda before miniforge is available (#3785) Adapt ESMValTool to new configuration (#3761) Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER (#3763) update comment in conda lock creation Github action (#3788) [Condalock] Update Linux condalock file (#3786) update Docker builds badge in README (#3783) Pin mamba<2 for conda-lock: solution by Ben Mares @maresb (#3771) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
iris=3.11
which is what we need to be able to unpincartopy
, see @schlunma 's comment Unpin cartopy #3769 (comment)cartopy==0.24
with an older iris egiris==3.10
, and hence get the bug we pinned cartopy for in the first place, we should piniris>=3.11
iris==3.11
works well withnumpy>=2
so we remove the upper pin in our own environment; note, however, that numpy2 is not yet available to us, due toncl
(that holdsesmpy
from going past 8.6, and makes us keep that sillyimportlib_metadata<8
pin, see Pin importlib_metadata <8 #3699)Closes #3769
Contributes to #3812
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.