-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use importlib
as the import mode for pytest
#3672
Conversation
Are you sure all the imports work like this? I'm a bit concerned about the missing |
On the other hand, the tests are passing, so it's probably fine. What's your opinion? Add |
As I understand it, I have just run the I would prefer not to add lots of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package-level imports are very good and very welcome, Emma, cheers! Note that Bouwe and me are doing that in #3646 since we added an __all__
member in the init, plus, this is the way to import anyway. I would, however, support Bouwe's idea to add init files - they don't need maintenance, since they be empty 🍺
Apologies for not replying to this sooner! I did some quick research into I haven't yet figured out the advantages and disadvantages for each approach / which is prefered / whether they can be used together, but it might be good to understand this before deciding what approach to take 👍 |
I think it will be simplest if we make ESMValTool a single package. At the moment, due to missing |
Description
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number of pull requests: