-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER #3763
Conversation
@flicj191 can you have a look please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @max-anu, it looks to be working well,
Can you have a look at the Codacy/CI tests? it looks like the downloader script needs an empty line at the end of it,
not sure why its not building the docs but I've suggested cleaning the whitespace in the table to make the file formatted cleaner
I would also add the filenames in the formatter script description string (esmvaltool/cmorizers/data/formatters/datasets/noaa_cires_20cr_v2.py) to complete it
Cheers
Co-authored-by: Felicity Chun <[email protected]>
Sanity checking values: tauu need to check the direction/positive attribute @max-anu: |
Thanks @flicj191 ! |
OK @flicj191 can you do a last pass and merge please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as well as the comment for the make negative, i'll try to look into the fail build
Data needs to be added to Levante first. |
Raw data and CMORised data has been copied to DKRZ: |
Description
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated data reformatting script
To help with the number of pull requests: