Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin mamba<2 for conda-lock: solution by Ben Mares @maresb #3771

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 15, 2024

Our conda lock file generation action is currently failing, the issue is obscure, but I did ask Ben at conda-lock if he's got any ideas, see conda/conda-lock#732 - for now I am testing about, see if pinning mamba helps, and as suggested by @maresb pinning mamba<2 is the correct approach, cheers, Ben! 🍺

Well, we'll test whenever core conda decides to work again, that is...

@valeriupredoi valeriupredoi changed the title try pin conda-lock<2.5.7 momentarily try pin mamba<2 for conda-lock Oct 15, 2024
@valeriupredoi valeriupredoi changed the title try pin mamba<2 for conda-lock pin mamba<2 for conda-lock: solution by Ben Mares @maresb Oct 15, 2024
@valeriupredoi valeriupredoi marked this pull request as ready for review October 15, 2024 15:17
@valeriupredoi
Copy link
Contributor Author

@maresb Ben, your idea to pin mamba works a treat, very many thanks! I'll leave this one on, and will close your fork PR #3773 but I am naming you here as the man with the idea 💡 😁

@maresb
Copy link

maresb commented Oct 15, 2024

Cool, thanks a lot!!! Also it's great to be correct! 😂

@valeriupredoi
Copy link
Contributor Author

@bettina-gier perhaps you have minute apply the Seal of Approval here too, please 🍺 @schlunma and @bouweandela are royally ignoring conda lock 😁

@schlunma
Copy link
Contributor

schlunma commented Oct 16, 2024

Sorry, been tied up in meetings all day 😩 Will approve once the tests finished 👍

@bettina-gier
Copy link
Contributor

Then I defer to @schlunma, was avoiding this PR cause I got 0 clue about conda-lock =D

@valeriupredoi
Copy link
Contributor Author

cheers, guys, not a worry, am just being pesky 🪰

@schlunma schlunma changed the title pin mamba<2 for conda-lock: solution by Ben Mares @maresb Pin mamba<2 for conda-lock: solution by Ben Mares @maresb Oct 16, 2024
@schlunma schlunma self-requested a review October 16, 2024 15:28
@schlunma schlunma added this to the v2.12.0 milestone Oct 16, 2024
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @valeriupredoi and @maresb!

Doc build fails due to #3762.

@valeriupredoi
Copy link
Contributor Author

legend! Cheers, chaps 🍺

@valeriupredoi valeriupredoi merged commit aa56eaa into main Oct 16, 2024
7 of 8 checks passed
@valeriupredoi valeriupredoi deleted the pin_conda-lock branch October 16, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants