Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update episode03_configuration #12

Merged
merged 27 commits into from
Jun 30, 2020
Merged

Update episode03_configuration #12

merged 27 commits into from
Jun 30, 2020

Conversation

SarahAlidoost
Copy link
Contributor

@SarahAlidoost SarahAlidoost commented Mar 13, 2020 •
edited
Loading

Pull Request checklist

We appreciate your time and effort to improve the tutorial. Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution.

Before you start

  • Read CONTRIBUTING.md.
  • Create an issue to discuss your idea. This allows your contributions to be incorporated into the tutorial.

Tasks

  • Give this pull request a descriptive title.
  • If you are contributing to existing lesson materials, please make sure the content conforms to the Lesson development section in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • If you are making a new episode, please make sure the content conforms to the Lesson organization and Lesson formatting sections in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • Preferably Codacy checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why.
  • Preview changes on your machine before pushing them to GitHub by running make serve, alternatively make docker-serve. Please see the Previewing your changes locally section in CONTRIBUTING.md for installation instructions.
  • All code instructions have been tested.

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.

Closes #11

@ledm ledm mentioned this pull request Mar 13, 2020
Open
@SarahAlidoost SarahAlidoost marked this pull request as ready for review March 13, 2020 16:05
ledm
ledm reviewed Mar 16, 2020
View reviewed changes
_episodes/03-configuration.md Outdated Show resolved Hide resolved
ledm
ledm reviewed Mar 16, 2020
View reviewed changes
_episodes/03-configuration.md Outdated Show resolved Hide resolved
@bouweandela
Copy link
Member

@ledm Are you OK with the changes? Can this be merged?

@SarahAlidoost SarahAlidoost changed the title episode03_configuration Update episode03_configuration Jun 29, 2020
sverhoeven
sverhoeven previously requested changes Jun 29, 2020
View reviewed changes
_episodes/03-configuration.md Outdated Show resolved Hide resolved
_episodes/03-configuration.md Outdated Show resolved Hide resolved
@SarahAlidoost
Copy link
Contributor Author

@sverhoeven, @LisaBock, @hb326, @bouweandela thank you for your helpful comments. I revised the text addressing your comments. It seems that some codacy issues cannot be fixed at this moment. Can we merge this pull request?

Peter9192
Peter9192 approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Sarah, let's merge and maybe add some final things in a final pass later on. I will try to solve a few more codacy things (newlines) before merging.

@hb326
Copy link
Contributor

hb326 commented Jun 30, 2020

@sverhoeven, @LisaBock, @hb326, @bouweandela thank you for your helpful comments. I revised the text addressing your comments. It seems that some codacy issues cannot be fixed at this moment. Can we merge this pull request?

Fine with me!

@Peter9192 Peter9192 dismissed sverhoeven’s stale review June 30, 2020 09:29

comments have been addressed.

@Peter9192 Peter9192 merged commit a674b4c into master Jun 30, 2020
@Peter9192 Peter9192 deleted the episode03_configuration branch June 30, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hb326 hb326 hb326 left review comments

@LisaBock LisaBock LisaBock left review comments

@Peter9192 Peter9192 Peter9192 approved these changes

@sverhoeven sverhoeven sverhoeven left review comments

@JaroCamphuijsen JaroCamphuijsen Awaiting requested review from JaroCamphuijsen

@ledm ledm Awaiting requested review from ledm

@bouweandela bouweandela Awaiting requested review from bouweandela

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Episode 03 (Configuration)
7 participants
@SarahAlidoost @bouweandela @hb326 @sverhoeven @ledm @Peter9192 @LisaBock