Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added webrick to gemfile to enable page rendering with ruby 3 #182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bvreede
Copy link
Contributor

@bvreede bvreede commented Feb 9, 2021

This change was necessary on my machine to generate the server with Ruby 3, as webrick no longer comes bundled with Ruby. I have not confirmed that it does not break the workflow with earlier versions of Ruby, however.

Pull Request checklist

We appreciate your time and effort to improve the tutorial. Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution.


Before you start

  • Read CONTRIBUTING.md.
  • Create an issue to discuss your idea. This allows your contributions to be incorporated into the tutorial.

Tasks

  • Give this pull request a descriptive title.
  • If you are contributing to existing lesson materials, please make sure the content conforms to the Lesson development section in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • If you are making a new episode, please make sure the content conforms to the Lesson organization and Lesson formatting sections in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • Preferably Codacy checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why.
  • Preview changes on your machine before pushing them to GitHub by running make serve, alternatively make docker-serve. Please see the Previewing your changes locally section in CONTRIBUTING.md for installation instructions.
  • All code instructions have been tested.

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #180

@bvreede
Copy link
Contributor Author

bvreede commented Feb 9, 2021

Can confirm that it still works with an earlier version of Ruby (2.6).

@Peter9192
Copy link
Contributor

Maybe we can also report this with https://github.com/carpentries/lesson-example and https://github.com/escience-academy/lesson-template, suggest this fix and see if they have any feedback/suggestions? I can imagine they have a better overview of how this should work than we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby 3 introduces new dependency
2 participants