Update the sdk bootstrap code to fail fast on clear problems with the lib from alfasim #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusse-martin
commented
Jun 14, 2024
Comment on lines
62
to
72
| #define LOAD_SDK_PROC_MAP_TYPE(func_name, func_type) {\ | ||
| dlerror();\ | ||
| api->func_name = (func_type)dlsym(api->handle, #func_name);\ | ||
| char *last_error = dlerror(); | ||
| if (last_error != NULL) {\ | ||
| dlclose(api->handle);\ | ||
| api->handle = nullptr;\ | ||
| return SDK_FAILED_TO_LOAD_FUNCTION;\ | ||
| }\ | ||
| } | ||
| #define LOAD_SDK_PROC(func_name) LOAD_SDK_PROC_MAP_TYPE(func_name, func_name ## _func) |
There was a problem hiding this comment.
It is many years since I wrote any macro.
Is this (and the ones in the other bootstrap file) OK?
… lib from alfasim The problems covered in this update: - Can not load the lib (not found or corrupted); - Can not fetch the address of a function from the lib; ASIM-5532
prusse-martin
force-pushed
the
fb-ASIM-5532-move-freeze-hooks-sdk-dll-load-fail-fast
branch
from
389605a to
dbf8d65
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problems covered in this update:
ASIM-5532