Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make the nature of content clearer #153

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

12rambau
Copy link
Contributor

In the end, the most misleading parameter for me was "binary" as it assumed I pass a file when I should instead pass the content of a file in a format that fits the data (bytes or text).

I updated the docstring to make it a bit clearer IMHO.

Fix #151

In the end, the most misleading parameter for me was "binary" as it assumed I pass a file when I should instead pass the content of a file in a format that fits the data (bytes or text).

I updated the docstring to make it a bit clearer IMHO.
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Appreciate it. 👍

@nicoddemus nicoddemus merged commit b795be7 into ESSS:master Nov 14, 2023
10 of 11 checks passed
@12rambau 12rambau deleted the patch-1 branch November 14, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file_regression check method don't accept Pathlib.Path
2 participants