-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a prescision parameter to data_regression #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
requested changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @12rambau for the PR, please see my comments.
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Bruno Oliveira <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Bruno Oliveira <[email protected]>
nicoddemus
reviewed
Dec 17, 2024
nicoddemus
reviewed
Dec 17, 2024
nicoddemus
reviewed
Dec 17, 2024
nicoddemus
reviewed
Dec 17, 2024
nicoddemus
reviewed
Dec 17, 2024
nicoddemus
reviewed
Dec 17, 2024
nicoddemus
approved these changes
Dec 17, 2024
tadeu
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
Thanks @12rambau! I will prepare a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #170
Fix #159
This PR add a
prescision
parameter to the data_regression check. If unset the behaviour remain unchanged, if setn then any float value in the data_dict will be rounded to the specified number of digits. It will allow to handle more complex data shapes directly in the data_regression fixture and keep them in a humanly readable file format: yaml.