Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.6 #174

Merged
merged 11 commits into from
Nov 10, 2023
Merged

Drop python 3.6 #174

merged 11 commits into from
Nov 10, 2023

Conversation

prusse-martin
Copy link
Member

ASIM-5273

@prusse-martin prusse-martin force-pushed the fb-ASIM-5273-drop-py36-qmx branch 3 times, most recently from 913fb97 to 6eedfd2 Compare November 1, 2023 17:38
@prusse-martin prusse-martin force-pushed the fb-ASIM-5273-drop-py36-qmx branch 2 times, most recently from e8737cc to b3c2aa4 Compare November 7, 2023 22:44
@prusse-martin prusse-martin force-pushed the fb-ASIM-5273-drop-py36-qmx branch 3 times, most recently from b52cbd0 to 824a38f Compare November 9, 2023 13:24
@prusse-martin prusse-martin marked this pull request as ready for review November 9, 2023 13:56
@BeneBr
Copy link

BeneBr commented Nov 9, 2023

ASIM-5273

Please in other PR's please add a link to task :=).

scripts/run_tests.sh Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

scripts/run_tests.sh Show resolved Hide resolved
tests/test_qt_js_integration.py Show resolved Hide resolved
@prusse-martin prusse-martin force-pushed the fb-ASIM-5273-drop-py36-qmx branch 4 times, most recently from a5a191e to 79f136f Compare November 10, 2023 14:31
By "Switch js tests env" read "get the conda env to resolve without
conflicts.

ASIM-5273
Avoid problems as
```
 /usr/share/miniconda/envs/qmxgraph/lib/python3.7/site-packages/more_itertools/more.py:5: in <module>
    from functools import cached_property, partial, reduce, wraps
E   ImportError: cannot import name 'cached_property' from 'functools' (/usr/share/miniconda/envs/qmxgraph/lib/python3.7/functools.py)
```

ASIM-5273
@prusse-martin prusse-martin force-pushed the fb-ASIM-5273-drop-py36-qmx branch from 79f136f to fa9d413 Compare November 10, 2023 19:11
@prusse-martin prusse-martin merged commit 697cb91 into master Nov 10, 2023
7 checks passed
@prusse-martin prusse-martin deleted the fb-ASIM-5273-drop-py36-qmx branch November 10, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants