New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EvaluatedPropertyReference from xxxPropertyType to align with updated 950002 Operations Test Model #21

Open

racheliurui opened this issue Aug 23, 2019 · 3 comments

Assignees

Labels

ERDi Medium MESA

Milestone

Collaborator

racheliurui commented Aug 23, 2019 •

edited by CharlieG021163

Loading

Background
ERDi, MESA: Refers to #49, #95, #101
In the updated 950002 Operations Test Model, the relationship source role name is not a required element for the "Corresponds to" unidirectional relationship from the Evaluated Property object (source) (under the Test Specification object) to the xxxProperty object (target, Testable Object Property). There is No reference attribute.
In B2MML, the EvaluatedPropertyReference element is not necessary and creates a circular reference since the Testable Object Property has a composite relationship to the Testable object which has the "specifies" relationship to associated TestSpecification element. The TestSpecifictionID identifies the defined the EvaluateProperty(s) by it composite relationship.

Supporting Document
950002 JWG5 CDV01 version (2019 12)
Clause 5.5.3 Equipment class property, Table 41 – Equipment class property relationship roles
Clause 5.5.5 Equipment property, Table 45 – Equipment property relationships
Clause 5.6.3 Physical asset class property, Table 51 – Physical asset class property relationship roles
Clause 5.6.5 Physical asset property. Table 55 – Physical asset property relationship roles
Clause 5.7.3 Material class property, Table 62 – Material class property relationship roles
Clause 5.7.5 Material definition property, Table 66 – Material definition property relationship roles
Clause 5.7.7 Material lot property, Table 70 – Material lot property relationship roles
Clause 5.9.1 Operations test model, Figure 16- Operations test model
Clause 5.9.7 Evaluated property, Table 109 – Evaluated property relationship roles
Clause 5.11.3 Operations event class property, Table 128 – Operations event class property relationship roles
950004 JWG5 CDV01 version (2019 12)
Clause 6.16.3 Workflow specification property, Table 33 – Workflow specification property relationship roles

Impacted Types and Solution
From the following types:
DELETE: <xsd:element name = "EvaluatedPropertyReference" type = "EvaluatedPropertyReferenceType" minOccurs = "0"/>

B2MML - Equipment.xsd
-EquipmentPropertyType
-EquipmentClassPropertyType
B2MML - Material.xsd
-MaterialClassPropertyType
-MaterialDefinitionPropertyType
-MaterialLotPropertyType
B2MML-PhysicalAsset.xsd
-PhysicalAssetClassPropertyType
-PhysicalAssetPropertyType
B2MML-Personnel.xsd
-PersonnelClassPropertyType
-PersonPropertyType
B2MML-OperationsEvent.xsd
-OperationsEventClassPropertyType
B2MML-WorkflowSpecification.xsd
-WorkflowPropertyType, Delete WorkflowPropertyType used for WorkflowSpecificationProperty element in WorkflowSpecificationType to align with updated 950004 #49 DELETED WorkflowPropertyType which DELETED EvaluatedPropertyReference element.

racheliurui referenced this issue


          Update B2MML-Equipment.xsd

4d4cded

ERDi, MESA:  Correct the following attribute names:
complexType name = "EquipmentType", Change "EquipmentChild" to "EquipmentChildID"
complexType name = "EquipmentType", Change "EquipmentPropertyChild" to "EquipmentPropertyChildID"
complexType name = "EquipmentClassType", Change "EquipmentClassChild" to "EquipmentClassChildID"
complexType name = "EquipmentClassType", Change "EquipmentClassPropertyChild" to "EquipmentClassPropertyChildID"

ERDi, MESA:  complexType name = "EquipmentType",  Change element name = "OperationalLocation" to  "OperationalLocationID.   Operational Location is a first order object and is exchanged as master data and then referenced by ID.

ERDi, MESA:  complexType name = "EquipmentPropertyType", Delete element name = "EvaluatedPropertyReference" type = "EvaluatedPropertyReferenceType".  This relationship attribute is a unidirectional relationship between the Evaluated Property object (source) in the TestSpecification object and the EquipmentProperty object (target) and so no reference attribute.

ERDi, MESA:  complexType name = "EquipmentClassPropertyType", Delete element name = "EvaluatedPropertyReference" type = "EvaluatedPropertyReferenceType".  This relationship attribute is a unidirectional relationship between the EvaluatedProperty object (source) in the TestSpecification object and the EquipmentClassProperty object (target)  so no  reference attribute.

Collaborator Author

racheliurui commented Aug 23, 2019

Supporting Document in ISA-950002

Section 5.9.1
Figure 16- Operations test model
Table xx - xxx property relationship roles (for example, Table 41 – Equipment class property relationship roles)

racheliurui referenced this issue


          Update B2MML - Material.xsd

48de858

ERDi, MESA: complexType name = "MaterialLotType", ADD element name = "Disposition", type = "DispositionType" to align with updated ISA-95 Part 2 Material Lot Object. Add DispositionType to Common Schema.

ERDi, MESA: complexType name = "MaterialSubLotType", ADD element name = "Disposition", type = "DispositionType" to align with updated ISA-95 Part 2 Material SubLot Object. Add DispositionType to Common Schema.

ERDi, MESA: complexType name = "MaterialLotType", element name ="StorageLocation"; Change type = "StorageHierarchyScopeType" to "ResourceLocationType" to align with updated ISA-95 Part 2 Material Lot Object.

ERDi, MESA: complexType name = "MaterialSubLotType", element name ="StorageLocation"; Change type = "StorageHierarchyScopeType" to "ResourceLocationType" to align with updated ISA-95 Part 2 Material Sublot Object.

ERDi, MESA: complexType name = "MaterialClassPropertyType", Delete element name = "EvaluatedPropertyReference" type = "EvaluatedPropertyReferenceType". This relationship attribute is a unidirectional relationship between the EvaluatedProperty object (source) in the TestSpecification object and the MaterialClassProperty object (target) so no reference attribute.

ERDi, MESA: complexType name = "MaterialDefinitionPropertyType", Delete element name = "EvaluatedPropertyReference" type = "EvaluatedPropertyReferenceType". This relationship attribute is a unidirectional relationship between the EvaluatedProperty object (source) in the TestSpecification object and the MaterailDefinitionProperty object (target) so no reference attribute.

ERDi, MESA: complexType name = "MaterialLotPropertyType", Delete element name = "EvaluatedPropertyReference" type = "EvaluatedPropertyReferenceType". This relationship attribute is a unidirectional relationship between the EvaluatedProperty object (source) in the TestSpecification object and the MaterialLotProperty object (target) so no reference attribute.

MaterialLotPropertyType: Delete TestResult. In updated Part 2, Test Result was removed from the material lot property object and included in the Operations Test Model. Test Result object has an association relationship to Material Actual and shall be added to the OpMaterailActual schema in the Common Schema. Also, Test Result object is now a 1st order object and should be added as a common schema with transactions.

racheliurui added ERDi MESA labels

racheliurui referenced this issue


          Update B2MML-PhysicalAsset.xsd

d13c777

ERDi, MESA: complexType name = "EvaluatedPropertyReference", DELETED element name = "EvaluatedPropertyReference" to to align with updated ISA-95 Part 2 Physical Asset Class.

CharlieG021163 added this to the AgreedByWorkingGroup milestone

racheliurui referenced this issue


          Update B2MML-PhysicalAsset.xsd

60935a3

ERDi, MESA: complexType name = "EquipmentType" / element name = "PhysicalAsset . Changed to "PhysicalAssetChild" to align with ISA-95 Part 2 identified role name. Current element name is not explicit about parent verses child (source and target). MESA may not do, ERDI should include in the schema.

racheliurui mentioned this issue

Delete WorkflowPropertyType used for WorkflowSpecificationProperty element in WorkflowSpecificationType to align with updated 950004 #49

Open

racheliurui added the Medium label

CharlieG021163 referenced this issue


          Update B2MML-Personnel.xsd

a958bb5

ERDi, MESA: complexType name = "PersonPropertyType", #31 
ADD:  element name = "PersonnelClassPropertyID"   type = "IdentifierType"  minOccurs = "0" maxOccurs = "1"/>

CharlieG021163 referenced this issue


          Update B2MML-PhysicalAsset.xsd

55a04cb

ERDi, MESA:   complexType name = "PhysicalAssetPropertyType" #31 
ADD:  element name = "PhysicalAssetClassPropertyID"  type = "IdentifierType"  minOccurs = "0" maxOccurs = "1"/>  

ERDi, MESA:   complexType name = "PhysicalAssetPropertyType" #12 
CHANGE:  element name = "PhysicalAssetProperty"  TO:  "PhysicalAssetPropertyChild"

Collaborator

CharlieG021163 commented Sep 23, 2019

The initial comment was updated with more impacted types and updated explanation.

CharlieG021163 added a commit that referenced this issue


          Update B2MML-OperationsEvent.xsd

316c911

ERDi, MESA: #21  complexType name = "OperationsEventClassPropertyType"
DELETE: element name = "EvaluatedPropertyReference"

ERDi, MESA:  #74 ComplexType name = "OperationsEventDefinitionType"> to align with update 950002, Clause 5.11.5 Operations event definition, Table 131 – Operations event definition relationship roles
ADD element name = "OperationsEventClassID    type = "IdentifierType"  minOccurs = "0" maxOccurs = "unbounded"/>

ERDi/MESA: #73 B2MML does not address the defined value for 4 elements in the OperationsEventType.
complexType name = "OperationsEventType
CHANGE:  element name = "OperationsEventType" type = "OperationsTypeType" 
   TO: type = "OperationsEventTypeType" 
CHANGE:  element name = "OperationsEventLevel" type = "NumericType" 
   TO: type = "OperationsEventLevelType"
CHANGE:  element name = "MOMFunction" type = "IdentifierType" 
   TO:  type = "MOMFunctionType"  
CHANGE:  element name = "EnterpriseFunction"  	type = "IdentifierType"
   TO:  type = "EnterpriseFunctionType"   
  
ERDi, MESA:  #31 complexType name = "OperationsEventPropertyType" element name = "OperationsEventDefinitionPropertyID" 
CHANGE:  type = "IdentifierType"  minOccurs = "0" maxOccurs = "unbounded"/>    
   TO:   type = "IdentifierType" />

CharlieG021163 assigned gerardmoloneyetpartners

CharlieG021163 added a commit that referenced this issue


          Update B2MML-Personnel.xsd

c89ea83

1. ERDI, MESA: #2  **Background**  In updated 950002 and 950004 models,  95 Committee agreed that the standard's convention is show the logical direction of all UML model relationships. Most relationships in models are unidirectional from a source object to a target object where the UML and XML best practice is applied with only the naming of target role element in the relationship role table for each object.  The current B2MML 7.0 beta is very inconsistent by having both source and target elements for unidirectional relationships in many types and having no source element in many types.
**Solution**  In B2MML: Change the name of existing source element of unidirectional relationship in schema to a naming convention of XXXSourceID from XXXXID. 

CHANGE:       "OperationalLocationClassType"  
<xsd:element name = "OperationalLocationID"       type = "IdentifierType"  minOccurs = "0" maxOccurs = "unbounded"/>
TO: "OperationalLocationSourceID"  

2. ERDi, MESA: #21  PersonPropertyType and PersonnelClassPropertyType
DELETE:   <xsd:element name = "EvaluatedPropertyReference" type = "EvaluatedPropertyReferenceType"   minOccurs = "0"/>

CharlieG021163 changed the title ~~Remove EvaluatedPropertyReference from xxxPropertyType~~ Remove EvaluatedPropertyReference from xxxPropertyType to align with updated 950002 Operations Test Model

CharlieG021163 modified the milestones: AgreedByWorkingGroup, AuthorisedForMESASubmission

This was referenced Mar 9, 2020

Add OperationsTest.xsd to align with updated 950002 #101

Open

Delete EvaluatedPropertyReferenceType from Common.xsd to align with Operations Test Model #95

Open

Dennis-Brandl commented Apr 14, 2020

I agree with the change.

terryrankine modified the milestones: AuthorisedForMESASubmission, AcceptedByMESA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment