Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete WorkflowPropertyType used for WorkflowSpecificationProperty element in WorkflowSpecificationType to align with updated 950004 #49

Open
racheliurui opened this issue Aug 28, 2019 · 3 comments
Open

Delete WorkflowPropertyType used for WorkflowSpecificationProperty element in WorkflowSpecificationType to align with updated 950004 #49

racheliurui opened this issue Aug 28, 2019 · 3 comments
Assignees
@gerardmoloneyetpartners
Labels
ERDi Issues that need to be fixed in ERDi version Medium MESA Issues that need to be fixed in MISA Version
Milestone
AcceptedByMESA

Comments

@racheliurui
Copy link
Collaborator

racheliurui commented Aug 28, 2019 •
edited by CharlieG021163
Loading

Background
ERDi, MESA:
The original B2MML complexType name = "WorkflowPropertyType" is incorrect and confusing since it does not align with updated 950004.

Impacted types
B2MML-WorkflowSpecification.xsd

  • WorkflowSpecificationType
  • WorkflowPropertyType
    -WorkflowSpecificationPropertyType

Solution

  1. DELETE: complexType name = "WorkflowPropertyType"
  2. complexType name = "WorkflowSpecificationType", WorkflowSpecificationProperty element,
    CHANGE: "WorkflowPropertyType"
    TO "WorkflowSpecificationPropertyType"

Other changes to updated "WorkflowSpecificationPropertyType" already covered by other issues,

Supporting document
ISA-950004 JWG5 CDV01 version (2019 12)
Clause 6.16.3 Workflow specification property
@racheliurui racheliurui added ERDi Issues that need to be fixed in ERDi version MESA Issues that need to be fixed in MISA Version labels Aug 28, 2019
@racheliurui racheliurui changed the title update WorkflowPropertyType to align with ISA-950004 change WorkflowPropertyType to WorkflowSpecificationPropertyType to align with ISA-950004 Sep 9, 2019
@racheliurui
Copy link
Collaborator Author

Agree

@racheliurui racheliurui mentioned this issue Sep 9, 2019
Closed
@racheliurui racheliurui added this to the AgreedByWorkingGroup milestone Sep 24, 2019
@racheliurui
Copy link
Collaborator Author

racheliurui commented Sep 24, 2019 •
edited
Loading

@CharlieG021163 want to re-write comment for this. Thus change the status to "Discussed & Commented".

@CharlieG021163 CharlieG021163 changed the title change WorkflowPropertyType to WorkflowSpecificationPropertyType to align with ISA-950004 Change WorkflowPropertyType to WorkflowSpecificationPropertyType to align with ISA-950004 Sep 26, 2019
CharlieG021163 referenced this issue Oct 17, 2019
@CharlieG021163
Update B2MML-WorkflowSpecification.xsd
d112914 
ERDi, MESA:  complexType name = "WorkflowSpecificationInformationType">
CHANGE:  
- element name = "WorkflowSpecificationType"   type = "WorkflowSpecificationTypeType"  TO
     "WorkflowSpecificationNodeType"   type = "WorkflowSpecificationNodeTypeType" 
ADD:
- element name = "WorkflowSpecificationConnectionType"   type = "WorkflowSpecificationConnectionTypeType" minOccurs = "0" maxOccurs = "unbounded"/>

ERDi, MESA:  complexType name = "WorkflowSpecificationType">
CHANGE:
- element name = "Node" minOccurs = "0" maxOccurs = "unbounded"/> TO 
     "WorkflowSpecificationNode" minOccurs = "1" maxOccurs = "unbounded"/>
- element name = "Connection" TO "WorkflowSpecificationConnection"
- element name = "WorkflowSpecificationProperty" type = "WorkflowPropertyType" TO 
     "WorkflowSpecificationProperty" type = "WorkflowSpecificationPropertyType" 
- element name = "IncludesThePropertiesOf" TO "WorkflowSpecificationNodeParent"
ADD:
- element name = "DefinitionType", type = "DefinitionTypeType", minOccurs = "0"/>

ERDi, MESA:  complexType name = "WorkflowPropertyType", 
CHANGE: 
- complexType name = "WorkflowPropertyType" TO  "WorkflowSpecificationPropertyType"
- element name = "WorkflowProperty" TO "WorkflowSpecificationPropertyChild"
DELETE:
- element name = "EvaluatedPropertyReference"
- element name = "TestResult"

ERDI, MESA: DELETE complexType name = "WorkflowSpecificationTypeType",  This is an intermediate type which simply refers to WorkflowSpecificationNodeTypeType and WorkflowSpecificationConnectionTypeType.  It is simply not needed especially since these types are individually exchanged as first order objects as master data.  Also, the name, WorkflowSpecificationType, is confusing since it implies that there is a type of Workflow Specification which there is not in the updated ISA-95 Part 2. 

ERDi, MESA: complexType name = "WorkflowSpecificationNodeType">
ADD:
- element name = "Version", type = "VersionType"  minOccurs = "0"/>
- element name = "EffectiveFrom", type = "DateTimeType"  minOccurs = "0" />	    
- element name = "EffectiveTo", type = "DateTimeType" minOccurs = "0" />
CHANGE: 
- element name = "NodeType" type = "IdentifierType" /> TO 
     "WorkflowSpecificationNodeTypeID type = "IdentifierType" minOccurs = "0" maxOccurs = "1"/>
- element name = "Property", type = "WorkflowSpecificationPropertyType" TO
      "WorkflowSpecifictionNodeProperty", type = "WorkflowSpecificationNodePropertyType"   
- element name = "IncludesThePropertiesOf" TO "WorkflowSpecificationNodeParent"
ADD: 
- element name = "WorkMasterID", type = "IdentifierType" />, minOccurs = "0" maxOccurs = "unbounded"/>
- element name = "WorkDirectiveID",type ="IdentifierType" />, minOccurs = "0" maxOccurs = "unbounded"/>

ERDi, MESA:  complexType name = "WorkflowSpecificationConnectionType"> 
CHANGE:
- element name = "ConnectionType" type = "IdentifierType" /> TO 
     "WorkflowSpecificationConnectionTypeID type = "IdentifierType" minOccurs = "0" maxOccurs = "1"/>
- element name = "FromNodeID" TO "FromWSNodeID" 
- element name = "ToNodeID" TO "ToWSNodeID" 
- element name = "Property", type = "WorkflowSpecificationPropertyType" TO
      "WorkflowSpecifictionConnectionProperty", type = "WorkflowSpecificationConnectionPropertyType"   
        
ERDi, MESA:  complexType name = "WorkflowSpecificationNodeTypeType"
ADD:
- element name = "Version", type = "VersionType"  minOccurs = "0"/>
- element name = "EffectiveFrom", type = "DateTimeType"  minOccurs = "0" />	    
- element name = "EffectiveTo", type = "DateTimeType" minOccurs = "0" />
CHANGE:
- element name = "Property", type = "WorkflowSpecificationPropertyType" TO
      "WorkflowSpecifictionNodeTypeProperty", type = "WorkflowSpecificationNodeTypePropertyType"   

ERDi, MESA:  complexType name = "WorkflowSpecificationConnectionTypeType"
ADD:
- element name = "Version", type = "VersionType"  minOccurs = "0"/>
- element name = "EffectiveFrom", type = "DateTimeType"  minOccurs = "0" />	    
- element name = "EffectiveTo", type = "DateTimeType" minOccurs = "0" />
CHANGE:
- element name = "Property", type = "WorkflowSpecificationPropertyType" TO
      "WorkflowSpecifictionConnectionTypeProperty", type = "WorkflowSpecificationConnectionTypePropertyType"
@CharlieG021163 CharlieG021163 changed the title Change WorkflowPropertyType to WorkflowSpecificationPropertyType to align with ISA-950004 Change WorkflowPropertyType to WorkflowSpecificationPropertyType in WorkflowSpecification.xsd to align with updated 950004 Jan 22, 2020
@CharlieG021163 CharlieG021163 changed the title Change WorkflowPropertyType to WorkflowSpecificationPropertyType in WorkflowSpecification.xsd to align with updated 950004 Delete WorkflowPropertyType used for WorkflowSpecificationProperty element in WorkflowSpecificationType to align with updated 950004 Mar 9, 2020
@racheliurui racheliurui mentioned this issue Mar 9, 2020
Open
@Dennis-Brandl
Copy link

I agree with the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerardmoloneyetpartners gerardmoloneyetpartners

Labels
ERDi Issues that need to be fixed in ERDi version Medium MESA Issues that need to be fixed in MISA Version
Projects
None yet
Milestone
AcceptedByMESA
Development

No branches or pull requests
6 participants
@terryrankine @racheliurui @CharlieG021163 @Dennis-Brandl @vitalJP @gerardmoloneyetpartners