-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change StorageLocation element from StorageHierarchyScopeType to ResourceLocationType in MaterialLotType and MaterialSubLotType #23
Comments
ERDi, MESA: complexType name = "MaterialLotType", ADD element name = "Disposition", type = "DispositionType" to align with updated ISA-95 Part 2 Material Lot Object. Add DispositionType to Common Schema. ERDi, MESA: complexType name = "MaterialSubLotType", ADD element name = "Disposition", type = "DispositionType" to align with updated ISA-95 Part 2 Material SubLot Object. Add DispositionType to Common Schema. ERDi, MESA: complexType name = "MaterialLotType", element name ="StorageLocation"; Change type = "StorageHierarchyScopeType" to "ResourceLocationType" to align with updated ISA-95 Part 2 Material Lot Object. ERDi, MESA: complexType name = "MaterialSubLotType", element name ="StorageLocation"; Change type = "StorageHierarchyScopeType" to "ResourceLocationType" to align with updated ISA-95 Part 2 Material Sublot Object. ERDi, MESA: complexType name = "MaterialClassPropertyType", Delete element name = "EvaluatedPropertyReference" type = "EvaluatedPropertyReferenceType". This relationship attribute is a unidirectional relationship between the EvaluatedProperty object (source) in the TestSpecification object and the MaterialClassProperty object (target) so no reference attribute. ERDi, MESA: complexType name = "MaterialDefinitionPropertyType", Delete element name = "EvaluatedPropertyReference" type = "EvaluatedPropertyReferenceType". This relationship attribute is a unidirectional relationship between the EvaluatedProperty object (source) in the TestSpecification object and the MaterailDefinitionProperty object (target) so no reference attribute. ERDi, MESA: complexType name = "MaterialLotPropertyType", Delete element name = "EvaluatedPropertyReference" type = "EvaluatedPropertyReferenceType". This relationship attribute is a unidirectional relationship between the EvaluatedProperty object (source) in the TestSpecification object and the MaterialLotProperty object (target) so no reference attribute. MaterialLotPropertyType: Delete TestResult. In updated Part 2, Test Result was removed from the material lot property object and included in the Operations Test Model. Test Result object has an association relationship to Material Actual and shall be added to the OpMaterailActual schema in the Common Schema. Also, Test Result object is now a 1st order object and should be added as a common schema with transactions.
During today's discussion, there seems to need more consideration for this change. Let's revisit this. |
This is related to open issue with B2MML Current model containing StorageLocation
Proposed change
Payload Comparison
<p:MaterialLot>
<p:ID>BlastholeID001935</p:ID>
<p:StorageLocation>LabA</p:StorageLocation>
</p:MaterialLot>
<p:MaterialLot>
<p:ID>BlastholeID001935</p:ID>
<p:StorageLocation>
<p:Location>LabA</p:Location>
<p:LocationType>Operational Location</p:LocationType>
</p:StorageLocation>
</p:MaterialLot> Agreed with this change. |
@CharlieG021163 has mentioned there would be more types being impacted by this change. Thus leave it at "discussed" stage |
Additional Changes:
ACTION |
ERDi, MESA: complexType name="OpPersonnelSpecificationType" #23 Align with updated ISA-95 Part 2 Operations Definition Object. ADD: element name="OperationalLocation" type="ResourceLocationType" minOccurs = "0" /> ERDi, MESA: complexType name="OpEquipmentSpecificationType" #23 Align with updated ISA-95 Part 2 Operations Definition Object. ADD: element name="OperationalLocation" type="ResourceLocationType" minOccurs = "0" /> ERDi, MESA: complexType name="OpPhysicalAssetSpecificationType" #23 Align with updated ISA-95 Part 2 Operations Definition Object. ADD: element name="PhysicalLocation" type="ResourceLocationType" minOccurs = "0" /> ERDi, MESA: complexType name="OpMaterialSpecificationType" #23 Align with updated ISA-95 Part 2 Operations Definition Object. ADD: element name="StorageLocation" type="ResourceLocationType" minOccurs = "0" />
@gerardmoloneyetpartners |
MESA have a large alternative proposal for us to review and provide feedback. The proposal is to: Remove StorageHierarchyScopeType and replace with ResourceLocationType Add a in ResourceLocationType to allow selection of either: <xsd:complexType name="ResourceLocationType1Type"> <xsd:complexType name="ResourceLocationTypeType"> Operational Location ID: storage location attribute references an operational location (OperationalLocationID); |
@gerardmoloneyetpartners @terryrankine |
I agree with the change (except to move of the OperationalLocation.xsd to common.) |
MESAInternational/B2MML-BatchML#30
Background and Solution
to align with updated 950002 Operational Location Model in Material Model, the following changes are required.
complexType name = "MaterialLotType", element name ="StorageLocation";
CHANGE: type = "StorageHierarchyScopeType" to "ResourceLocationType"
complexType name = "MaterialSubLotType", element name ="StorageLocation";
CHANGE: type = "StorageHierarchyScopeType" to "ResourceLocationType"
Impacted Types
Material.xsd
Supporting Document
950002 JWG5 CDV01 version (2019 12)
Clause 5.7.6 Material lot, Table 69 – Material lot attributes
Clause 5.7.8 Material sublot, Table 73 – Material sublot attributes
The text was updated successfully, but these errors were encountered: