-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused signature features #79
base: main
Are you sure you want to change the base?
Conversation
- only create xmldsig framgnets which are listed (like other fragments) - remove unused fields for optimization (per default remove "shall not be used" from standard) removed elements are not in structure and will result in en/decoder error NOT_IMPLEMENTED when "isUsed" flag is set. Signed-off-by: Michael Mezger <[email protected]>
The change is not optimal. |
Notes for us when reviewing this:
|
For the record, from my experiments:
Our regression tests seem to pass. |
If we take this in, we should also do the same optimizations for DIN and ISO 15118-20. Applied to DIN and ISO -20:
With a modified version of this PR, rebased on HEAD:
|
Describe your changes
removed elements are not in structure and will result in en/decoder error NOT_IMPLEMENTED when "isUsed" flag is set or element is accessed in decoder.
Issue ticket number and link
Feature request #75
Checklist before requesting a review