- Address feedback

- Add new assertion handler for asserting an action does not throw an exception

EasyPost.Tests/ClientTest.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Linq;
 using System.Net;
 using System.Net.Http;
 using System.Threading;
@@ -9,6 +8,7 @@
 using EasyPost.Tests._Utilities;
 using EasyPost.Tests._Utilities.Attributes;
 using Xunit;
+using CustomAssertions = EasyPost.Tests._Utilities.Assertions.Assert;
 
 namespace EasyPost.Tests
 {
@@ -74,9 +74,7 @@ public void TestThreadSafety()
         public void TestClientDisposal()
         {
             Client client = new(new ClientConfiguration(FakeApikey));
-            client.Dispose();
-
-            // As long as this test doesn't throw an exception, it passes
+            CustomAssertions.DoesNotThrow(() => client.Dispose());
         }
 
         [Fact]

EasyPost.Tests/HttpTests/ClientConfigurationTest.cs

@@ -1,6 +1,7 @@
 using System;
 using EasyPost.Tests._Utilities.Attributes;
 using Xunit;
+using CustomAssertions = EasyPost.Tests._Utilities.Assertions.Assert;
 
 namespace EasyPost.Tests.HttpTests
 {
@@ -12,10 +13,7 @@ public class ClientConfigurationTest
         public void TestClientConfigurationDisposal()
         {
             ClientConfiguration configuration = new("not_a_real_api_key");
-
-            configuration.Dispose();
-
-            // As long as this test doesn't throw an exception, it passes
+            CustomAssertions.DoesNotThrow(() => configuration.Dispose());
         }
 
         [Fact]

EasyPost.Tests/HttpTests/RequestTest.cs

@@ -2,6 +2,7 @@
 using EasyPost._base;
 using EasyPost.Http;
 using Xunit;
+using CustomAssertions = EasyPost.Tests._Utilities.Assertions.Assert;
 
 namespace EasyPost.Tests.HttpTests;
 
@@ -13,10 +14,7 @@ public class RequestTest
     public void TestRequestDisposal()
     {
         Request request = new("https://google.com", "not_a_real_endpoint", Method.Get, ApiVersion.V2, new Dictionary<string, object> { { "key", "value" } }, new Dictionary<string, string> { { "header_key", "header_value" } });
-
-        request.Dispose();
-
-        // As long as this test doesn't throw an exception, it passes
+        CustomAssertions.DoesNotThrow(() => request.Dispose());
     }
 
     #endregion

EasyPost.Tests/ServicesTests/ServiceTest.cs

@@ -10,6 +10,7 @@
 using EasyPost.Tests._Utilities.Attributes;
 using EasyPost.Utilities.Internal.Attributes;
 using Xunit;
+using CustomAssertions = EasyPost.Tests._Utilities.Assertions.Assert;
 
 namespace EasyPost.Tests.ServicesTests
 {
@@ -28,9 +29,7 @@ public void TestServiceDisposal()
             Client client = new(new ClientConfiguration("not_a_real_api_key"));
 
             AddressService addressService = client.Address;
-            addressService.Dispose();
-
-            // As long as this test doesn't throw an exception, it passes
+            CustomAssertions.DoesNotThrow(() => addressService.Dispose());
         }
 
         /// <summary>

EasyPost.Tests/_Utilities/Assertions/AnyException.cs

@@ -3,7 +3,7 @@
 namespace EasyPost.Tests._Utilities.Assertions
 {
     /// <summary>
-    /// Exception thrown when an Any assertion has one or more items fail an assertion.
+    ///     Exception thrown when an Any assertion has one or more items fail an assertion.
     /// </summary>
     public class AnyException : XunitException
     {

EasyPost.Tests/_Utilities/Assertions/CollectionAsserts.cs

@@ -6,12 +6,6 @@ namespace EasyPost.Tests._Utilities.Assertions
     // ReSharper disable once PartialTypeWithSinglePart
     public abstract partial class Assert
     {
-        private static void GuardArgumentNotNull(string argName, object argValue)
-        {
-            if (argValue == null)
-                throw new ArgumentNullException(argName);
-        }
-
         /// <summary>
         /// Verifies that any items in the collection pass when executed against
         /// action.

EasyPost.Tests/_Utilities/Assertions/DoesNotThrowAssert.cs

@@ -0,0 +1,50 @@
+using System;
+
+namespace EasyPost.Tests._Utilities.Assertions
+{
+    // ReSharper disable once PartialTypeWithSinglePart
+    public abstract partial class Assert
+    {
+        /// <summary>
+        ///     Verifies that an action does not throw an exception.
+        /// </summary>
+        /// <param name="action">The action to test</param>
+        /// <exception cref="DoesNotThrowException">Thrown when the action throws an exception</exception>
+        public static void DoesNotThrow(Action action)
+        {
+            GuardArgumentNotNull(nameof(action), action);
+
+            try
+            {
+                action();
+            }
+            catch (Exception ex)
+            {
+                throw new DoesNotThrowException(ex);
+            }
+        }
+
+        /// <summary>
+        ///     Verifies that an action does not throw a specific exception.
+        /// </summary>
+        /// <param name="action">The action to test</param>
+        /// <typeparam name="T">The type of the exception to not throw</typeparam>
+        /// <exception cref="DoesNotThrowException">Thrown when the action throws an exception of type T</exception>
+        public static void DoesNotThrow<T>(Action action) where T : Exception
+        {
+            GuardArgumentNotNull(nameof(action), action);
+
+            try
+            {
+                action();
+            }
+            catch (Exception ex)
+            {
+                if (ex.GetType() == typeof(T))
+                {
+                    throw new DoesNotThrowException(ex);
+                }
+            }
+        }
+    }
+}

EasyPost.Tests/_Utilities/Assertions/DoesNotThrowException.cs

@@ -0,0 +1,19 @@
+using System;
+using Xunit.Sdk;
+
+namespace EasyPost.Tests._Utilities.Assertions
+{
+    /// <summary>
+    ///     Exception thrown when a DoesNotThrow assertion fails.
+    /// </summary>
+    public class DoesNotThrowException : XunitException
+    {
+        /// <summary>
+        ///     Creates a new instance of the <see cref="DoesNotThrowException"/> class.
+        /// </summary>
+        public DoesNotThrowException(Exception ex)
+            : base("Assert.DoesNotThrow() Failure", ex)
+        {
+        }
+    }
+}

EasyPost.Tests/_Utilities/Assertions/GuardArgumentNotNull.cs

@@ -0,0 +1,14 @@
+using System;
+
+namespace EasyPost.Tests._Utilities.Assertions
+{
+    // ReSharper disable once PartialTypeWithSinglePart
+    public abstract partial class Assert
+    {
+        private static void GuardArgumentNotNull(string argName, object argValue)
+        {
+            if (argValue == null)
+                throw new ArgumentNullException(argName);
+        }
+    }
+}

EasyPost/_base/EasyPostService.cs

@@ -74,7 +74,6 @@ protected virtual void Dispose(bool disposing)
             // Dispose managed state (managed objects)
 
             // Don't dispose of the associated client here, as it may be shared among multiple services
-            // Client.Dispose();
         }
 
         /// <summary>