Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Remove CreateAndBuy function for Batch service #526

Merged
merged 2 commits into from
Nov 30, 2023
Merged

[chore] Remove CreateAndBuy function for Batch service #526

merged 2 commits into from
Nov 30, 2023

Conversation

nwithan8
Copy link
Contributor

Description

create_and_buy endpoint no longer supported at the API level. This PR removes associated functions.

Testing

  • Remove related unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested review from a team, jchen293 and Justintime50 November 30, 2023 00:00
@nwithan8 nwithan8 merged commit 9dbf4de into master Nov 30, 2023
@nwithan8 nwithan8 deleted the create_and_buy branch November 30, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

@Justintime50 Justintime50 Justintime50 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @Justintime50