Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Recursion causing stack overflow when disposing client/service #588

Merged
merged 5 commits into from
Sep 17, 2024
Merged

[fix] Recursion causing stack overflow when disposing client/service #588

merged 5 commits into from
Sep 17, 2024

Commits on Sep 17, 2024

  1. - Fix recursion causing stack overflow when disposing client/service 

    - Add unit tests to verify disposal does not cause stack overflow
Closes #587
    @nwithan8
    nwithan8 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ab3d1c0 View commit details
    Browse the repository at this point in the history

  2. - Update changelog

    @nwithan8
    nwithan8 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c07e131 View commit details
    Browse the repository at this point in the history

  3. - Don't dispose of client via service due to shared reference (servic… 

    …e can be diposed of via client)
    @nwithan8
    nwithan8 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0aa9bf4 View commit details
    Browse the repository at this point in the history

  4. - Linting

    @nwithan8
    nwithan8 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f0ec5ea View commit details
    Browse the repository at this point in the history

  5. - Address feedback 

    - Add new assertion handler for asserting an action does not throw an exception
    @nwithan8
    nwithan8 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    85cb8a3 View commit details
    Browse the repository at this point in the history