Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: publish #330

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: publish #330

merged 1 commit into from
Aug 9, 2024

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Aug 9, 2024 •
edited
Loading

Description

It's possible our makefile is getting in the way of the setup-java action being able to pass around creds correctly.

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team August 9, 2024 21:10
@Justintime50 Justintime50 merged commit e262e45 into master Aug 9, 2024
18 checks passed
@Justintime50 Justintime50 deleted the fix_release branch August 9, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Justintime50 @jchen293