EEH-2506 - Modified "phenotypes" and "diseases" arrays #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now phenotypes is phenotipicAbnormality and both this one and the diseases array can explicitly negate the items with "excluded" property
|
Found at the testing a "phenotypes" reference that wasn't amended. Amended it here: #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket reference
EEH-2506
Overall changes
excludedproperty so that logic negation of diseases and phenotypes can be madeFuture TO-DOs
async keyword in sync schemaelixir-europe/biovalidator#57), I couldn't test that the JSON examples are valid against the schemas. Once merged I'll test it and amend it otherwise.