-
-
Notifications
You must be signed in to change notification settings - Fork 62.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CONTRIBUTING-ta.md (Tamil review help requested) #11350
base: main
Are you sure you want to change the base?
Conversation
Hi @eshellman , |
Hi @eshellman @ashwingopalsamy |
Hey @Ritika-K7, I'd suggest fixing the formatting. I'll be adding my comments on this, in your PR. On a side note, for everyone: going forward, please include the PR link in the comments when a review is needed. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 I noticed a few areas where the 'Tamil' translation lacks context. While I appreciate the effort in using AI LLMs for the translation, it'd be great if you could put in a bit more work to improving the translation.
Please address them or share your improvements on the existing PR (#11356). Thanks!
* [இதை மற்ற மொழிகளில் படிக்கவும்] (README.md #translations) * | ||
|
||
|
||
#பங்களிப்பாளர் உரிம ஒப்பந்தம் |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown Title needs to be addressed correctly here.
docs/CONTRIBUTING-ta.md
Outdated
பங்களிப்பதன் மூலம், இந்த களஞ்சியத்தின் உரிமத்திற்கு (../உரிமம்) நீங்கள் ஒப்புக்கொள்கிறீர்கள். | ||
|
||
|
||
#பங்களிப்பாளர் நடத்தை விதிகள் |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too. Please ensure the file is well formatted, to highlight the differences between titles, sub-headings.
docs/CONTRIBUTING-ta.md
Outdated
|
||
#பங்களிப்பாளர் உரிம ஒப்பந்தம் | ||
|
||
பங்களிப்பதன் மூலம், இந்த களஞ்சியத்தின் உரிமத்திற்கு (../உரிமம்) நீங்கள் ஒப்புக்கொள்கிறீர்கள். |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't any file named ../உரிமம்
. Please have a look on what and where this directory is and ensure to add the right path (in English) here.
Changes made to : EbookFoundation#11350
Hi @eshellman @ashwingopalsamy Changes made to:#11350 |
Oh no 😟! Conflicts have been found. Please 🙏, take a moment and address the merge conflicts of your pull request before we can evaluate it again. Thanks in advance for your effort and patience ❤️! |
Hi @eshellman @ashwingopalsamy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can still see a lot of room for improvements and the existing PR comments are yet to be addressed. If you need more help understanding the highlighted suggestions, please reply back in the comments.
```bash | ||
சிறப்பு check_urls = free-programming-books.md free-programming-books-en.md | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bash script may not use 'Tamil' language. Please review your changes once again. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR Title signifies, this pull request adds a 'CONTRIBUTING' file for 'Tamil', but I can also see a Hindi version of the same.
I would suggest using a separate PR for adding the 'Hindi' version.
பங்களிப்பதன் மூலம், இந்த களஞ்சியத்தின் [உரிமம்](../LICENSE) நீங்கள் ஒப்புக்கொள்கிறீர்கள். | ||
|
||
|
||
##பங்களிப்பாளர் நடத்தை விதிகள் |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format this Markdown Heading (H2) accordingly.
I appreciate your efforts in translating to 'Tamil' though you aren't fluent in 'Tamil', but I would suggest to review the translation provided by the AI LLMs once before raising the PR, to save time for both of us. 😉 |
@Ritika-K7 please follow the suggestions of @ashwingopalsamy |
What does this PR do?
Add resource(s)| specifically, a translated version of the
CONTRIBUTING.md
fileFor resources
Description
This PR includes a Tamil translation of the
CONTRIBUTING.md
file, making the contribution guidelines accessible to Tamil-speaking contributors.Why is this valuable (or not)?
This translation is valuable because it opens up the project to a broader audience, allowing Tamil speakers to understand and follow the contribution guidelines more easily. This may encourage more contributions from this community.
How do we know it's really free?
The original
CONTRIBUTING.md
file is an open-source resource that provides contribution guidelines for the repository. The translated version adheres to the same principles of openness and accessibility.For book lists, is it a book? For course lists, is it a course? etc.
This PR does not add a book or course; it improves the repository by providing a translated resource.
Checklist:
Follow-up