-
-
Notifications
You must be signed in to change notification settings - Fork 61.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add License To Two Books #11636
Open
kahenya-anita
wants to merge
3
commits into
EbookFoundation:main
Choose a base branch
from
kahenya-anita:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add License To Two Books #11636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linter failed, fix the error(s):
|
github-actions
bot
added
the
linter error
Please, correct build errors found by linter!
label
Oct 21, 2024
Linter failed, fix the error(s):
|
eshellman
reviewed
Oct 21, 2024
@@ -247,7 +247,7 @@ Books on general-purpose programming that don't focus on a specific language are | |||
* [Ada Reference Manual - ISO/IEC 8652:2012(E) Language and Standard Libraries](http://www.ada-auth.org/standards/12rm/RM-Final.pdf) (PDF) | |||
* [Introduction To Ada](https://learn.adacore.com/courses/intro-to-ada/index.html) | |||
* [Introduction To SPARK](https://learn.adacore.com/courses/SPARK_for_the_MISRA_C_Developer/index.html) | |||
* [The Big Online Book of Linux Ada Programming](http://www.pegasoft.ca/resources/boblap/book.html) | |||
* [The Big Online Book of Linux Ada Programming](http://www.pegasoft.ca/resources/boblap/book.html) (LGPL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a section about licensing in general, not a license for the book. Also, we're not supporting the LGPL as a license option because that license doesn't make sense for books.
eshellman
added
the
waiting for changes
PR has been reviewed and changes/suggestions requested
label
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
linter error
Please, correct build errors found by linter!
waiting for changes
PR has been reviewed and changes/suggestions requested
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add resource(s)
Add info on the basis of https://github.com/EbookFoundation/free-programming-books/issues/11355
Description
License (CC BY-NC-SA) found in the landing page
License (LGPL) found in the Licensing option
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:
Follow-up