Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated train_on_episode_end #320

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LucaVendruscolo
Copy link

Hello, I had a few issues with git so I deleted my old fork #319 and started again. I made all the requested changes and did some general testing on all the algorithms to confirm it worked with them too. Let me know if there's anything else you'd like me to add/change.

Thanks so much for the help!

@belerico
Copy link
Member

belerico commented Oct 5, 2024

Hi @LucaVendruscolo, do you have some empirical evidence that everything is working? Some plots for example

@LucaVendruscolo
Copy link
Author

I will run the tests and take some screenshots now

@LucaVendruscolo
Copy link
Author

The log files: logs.zip
image
grey line is train_on_episode_end: false and blue line is train_on_episode_end: true
running:
python sheeprl.py exp=dreamer_v3 env=gym env.id=CartPole-v1 env.num_envs=4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants