Correctly report the required size to paint the PGroup control #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if the the content of the PGroup is smaller than the title area width the text is cropped and possibly not readable because the PGroup does not report the title area with as it preferred width. This now changes the computation so that the hints are passed to the render and then it could report the desired size.
laeubi
force-pushed
the
pgroup_wrong_size
branch
from
36b4ba8 to
42e943d
Compare
|
Thank you @laeubi for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the the content of the PGroup is smaller than the title area width the text is cropped and possibly not readable because the PGroup does not report the title area with as it preferred width.
This now changes the computation so that the hints are passed to the render and then it could report the desired size.
The problem can be seen with the PGroupSnippet1.java already here it is how it is shown before (under Linux):
As one can see, even though there is enough space left, the title is abbreviated and hardly readable.
After this change it looks like this: