Correct Snow precipitation #282
Conversation
There was a problem hiding this comment.
Hi @MostafaGomaa93, Thanks for your efforts.
Could you please add the definitions of input and output variables in the functions related to your changes (add references if possible)? Additionally, for the new-added variables, let's follow the MATLAB Guidelines 2.0 about naming conventions
| % Apply the surface boundary condition called for by BoundaryCondition.NBCh | ||
| %%%%%% Apply the surface boundary condition called for by BoundaryCondition.NBCh %%%%%% | ||
| Precip = ForcingData.Precip_msr(KT); % total precipitation (liquid + snow) | ||
| R_Dunn = ForcingData.Runoff_Dunn(KT); % Dunnian runoff (calculated in +io/loadForcingData file) |
There was a problem hiding this comment.
| R_Dunn = ForcingData.Runoff_Dunn(KT); % Dunnian runoff (calculated in +io/loadForcingData file) | |
| runoffDunn = ForcingData.runoffDunn(KT); % Dunnian runoff (calculated in +io/loadForcingData file) |
| ForcingData.Precip_snow = Precip_snow; | ||
| ForcingData.Precip_snowAccum = Precip_snowAccum; | ||
| ForcingData.infiltration = infiltration; | ||
| ForcingData.runoffDunn = runoffDunn; |
There was a problem hiding this comment.
Is the ForcingData.runoffDunn the same as ForcingData.runoffDunnian? Do you mean ForcingData.runoffDunnian here? Please double-check which variable you want to save here.
There was a problem hiding this comment.
Yes, they are the same. The difference is that ForcingData.runoffDunn is a 1D array but ForcingData.runoffDunnian is a time-series array. and the ForcingData.runoffDunn is needed in BMI
There was a problem hiding this comment.
ForcingData.runoffDunnis needed in BMI
Should we make it explicitly clear then? something like ForcingData.runoffDunn_BMI ?
| @@ -46,6 +46,6 @@ | |||
| else | |||
| L_ts = L(n); | |||
| SH = 0.1200 * Constants.c_a * (SoilVariables.T(n) - ForcingData.Ta_msr(KT)) / r_a_SOIL(KT); | |||
| RHS(n) = RHS(n) + 100 * Rn_SOIL(KT) / 1800 - Constants.RHOL * L_ts * Evap - SH + Constants.RHOL * Constants.c_L * (ForcingData.Ta_msr(KT) * Precip(KT) + BoundaryCondition.DSTOR0 * SoilVariables.T(n) / Delt_t); % J cm-2 s-1 | |||
| RHS(n) = RHS(n) + 100 * Rn_SOIL(KT) / 1800 - Constants.RHOL * L_ts * Evap - SH + Constants.RHOL * Constants.c_L * (ForcingData.Ta_msr(KT) * ForcingData.infiltration + BoundaryCondition.DSTOR0 * SoilVariables.T(n) / Delt_t); % J cm-2 s-1 | |||
There was a problem hiding this comment.
@yijianzeng @Yunfei-Wang1993 @Lianyu-Yu Could you please help explain what these variables mean, their units and references (if possible)?Evap, Delt_t, r_a_SOIL, Rn_SOIL, RHS, L, L_ts, SH, BoundaryCondition.DSTOR0, SoilVariables.T?
There was a problem hiding this comment.
Hi @Crystal-szj, i had a look at the original STEMMUS code, and suggest the following:
Evap is Evaporation (g cm^2 s^-1)
Delt_t is the time step (here, it is 1800s)
r_a_SOIL is soil surface aerodynamic resistance (s cm^-1)
Rn_SOIL is net radiation reaching the soil surface
L is the latent heat of vaporization, Line47 'L_ts=L(n)' could be added by Lianyu.
|
Thank you, @MostafaGomaa93, for your efforts. I tested your branch and it works well. I ran 10 timesteps against Hi @yijianzeng, we need your review to unlock the merge. Could you please review the changes Mostafa made to correct the calculation of precipitation/snow when the soil temperatures are below zero? |
@Crystal-szj, does it make sense to post the test results after you, Mostafa, or others have done this step? |
Hi @yijianzeng, thanks for your suggestions. I have added the comparison here. |
Description
Closes #279
Closes #280
Relates #281
Checklist
linter, below the pull request, are
successful (green).
Unreleased.