Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactor to push generic methods to other packages #31

Merged
merged 20 commits into from
Jun 23, 2019

Conversation

kescobo
Copy link
Member

@kescobo kescobo commented Jun 10, 2019

Removing DistanceMatrix and PCoA types and Methods in favor of Distances.jl and MultivariateStats.jl

Types of changes

This PR implements the following changes:
(Please tick any or all of the following that are applicable)

  • 🐛 Bug fix (A non-breaking change, which fixes an issue).
  • 💥 Breaking change (fix or feature that would cause existing functionality to change).

📋 Additional detail

☑️ Checklist

  • 🎨 The changes implemented is consistent with the julia style guide.
  • 📘 I have updated and added relevant docstrings, in a manner consistent with the documentation styleguide.
  • 📘 I have added or updated relevant user and developer manuals/documentation in docs/src/.
  • 🆗 There are unit tests that cover the code changes I have made.
  • 🆗 The unit tests cover my code changes AND they pass.
  • 📝 I have added an entry to the [UNRELEASED] section of the manually curated CHANGELOG.md file for this repository.
  • 🆗 All changes should be compatible with the latest stable version of Julia.
  • 💭 I have commented liberally for any complex pieces of internal code.

@kescobo kescobo changed the title Removing DistanceMatrix and PCoA types and Methods in favor of Distances.jl and MultivariateStats.jl Major refactor to push generic methods to other packages Jun 11, 2019
@kescobo
Copy link
Member Author

kescobo commented Jun 23, 2019

Merging, though can't be released while waiting on several other packages to make releases.

@kescobo kescobo merged commit 3a07bfa into EcoJulia:master Jun 23, 2019
@kescobo kescobo deleted the kevdev-1 branch June 23, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant