-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major refactor to push generic methods to other packages #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and MultivariateStats
kescobo
changed the title
Removing DistanceMatrix and PCoA types and Methods in favor of Distances.jl and MultivariateStats.jl
Major refactor to push generic methods to other packages
Jun 11, 2019
Merging, though can't be released while waiting on several other packages to make releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing DistanceMatrix and PCoA types and Methods in favor of Distances.jl and MultivariateStats.jl
Types of changes
This PR implements the following changes:
(Please tick any or all of the following that are applicable)
📋 Additional detail
DistanceMatrix
typegetdm(::AbundanceTable, BrayCurtis())
, will usepairwise(BrayCurtis(), ::AbundanceTable)
. Depends on Addpairwise()
method from Distances.jl SpatialEcology.jl#36pcoa(::DistanceMatrix)
, usefit(::MDS, ::Array{Number, 2})
☑️ Checklist
docs/src/
.[UNRELEASED]
section of the manually curatedCHANGELOG.md
file for this repository.