Nitrogen Test #86
Merged
Nitrogen Test #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests comparted against FORTRAN code and HEC-RAS WQ. All cases match HEC-RAS WQ besides adjustments to variables use_NH4 and use_NO3 which matches FORTRAN code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 80.61% 80.62% +0.01%
==========================================
Files 27 27
Lines 1842 1843 +1
==========================================
+ Hits 1485 1486 +1
Misses 357 357 ☔ View full report in Codecov by Sentry. |
imscw95
approved these changes
Jun 4, 2024
sjordan29
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests compared against FORTRAN code and HEC-RAS WQ. All cases match FORTRAN code. All cases besides adjustments to variables use_NH4 and use_NO3 also match HEC-RAS WQ.