Ijm nsm v2 #87
Merged
Ijm nsm v2 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 of 61 tests are failing, one by .01, and one because of an issue probably due to initial conditions in RAS modules.
|
@imscw95, there is one more conflict to resolve. Can you take a look? |
|
Resolved, removed print statement from Kelsey's branch @kewalak that ok? |
|
I am going to update the theta issue before merging this branch, because the changes I made to the hardcoded theta values led to failures in some of the test files. Going to try to solve this before merging. |
|
@imscw95, thanks for keeping this moving forward! Time is getting tight on this deliverable and really appreciate your effort. |
…eam/ClearWater-modules into IJM_NSM_v2" This reverts commit b79d552, reversing changes made to 5c2ece4.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added carbon, DOX, alkalinity, and CBOD test files. Made edits to the processes.py file where necessary to get the modules to match RAS and the hand calculations.