Update EntityViewInspector #67
Conversation
|
Hello, thanks for the PR will get it merged in. I just want to mention that the editor stuff in here for Unity was a proof of concept it was never really fleshed out so you will probably find lots of janky bits in there. There was a branch created AGES ago which tried to do a bit too much (handle persistence of entities external to scene, update editors and a few other bits). So if you are doing a lot in this space you may be able to take some of the code from this branch but I honestly cant remember what state it was in, the editor stuff seemed ok but the whole persistence layer was flakey. https://github.com/EcsRx/ecsrx.unity/tree/editor-upgrade/src/Assets/EcsRx |
|
Off the back of this I had a stab at updating the editors based off that branch and put the branch up, so it may be worth giving that a look, its mentioned more in here #68 |
Hello! I noticed that when opening a custom inspector for the "EntityView" type in runtime, Unity is lagging. This happens due to access to the allComponentTypes field inside the EntityViewInspector script. The ".SelectMany()" and ".Where()" methods are deferred methods. This means that they will not be executed until the method with immediate execution is called.
Because of this, a resource-intensive operation of iterating over all classes in all assemblies is performed every time ".OnInspectorGUI()" is called.
To fix this you just need to add a linq method with immediate execution when initializing the "allComponentTypes" field. For example ".ToArray()".