Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data: hariFED #10263

Merged
merged 3 commits into from
Mar 12, 2024
Merged

data: hariFED #10263

merged 3 commits into from
Mar 12, 2024

Conversation

hariFED
Copy link
Contributor

@hariFED hariFED commented Mar 11, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions bot added invalid Inappropriate or invalid for Hacktoberfest contributions ✍ chore: profile This label will be added on PR with request of Data json addition labels Mar 11, 2024
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filename should exactly match your GitHub username (it's case specific). Please rename your filename here to hariFED.json

Change harifed.json --> hariFED.json

@hariFED
Copy link
Contributor Author

hariFED commented Mar 11, 2024

Hi @kumarsonsoff3 as you mentioned in the review the file name harifed.json is renamed to hariFED.json.

@hariFED hariFED requested a review from kumarsonsoff3 March 12, 2024 04:28
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks for Contributing! 🎉

@kumarsonsoff3 kumarsonsoff3 merged commit 8937d0e into EddieHubCommunity:main Mar 12, 2024
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants