Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data :AzraNaseri #10287

Merged

Conversation

AzraNaseri
Copy link
Contributor

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions bot added invalid Inappropriate or invalid for Hacktoberfest contributions ✍ chore: profile This label will be added on PR with request of Data json addition labels Mar 15, 2024
Comment on lines 12 to 14
"social": [
{
"name": "Follow me on LinkedIn",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Socials don't require a name key. Also there is a missing s in "socials"

Suggested change
"social": [
{
"name": "Follow me on LinkedIn",
"socials": [
{

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the codes and implemented what you mentioned. So why has it still not merged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and how can i open my codes in the browser i mean to see the result (profile)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll find your profile at https://biodrop.io/AzraNaseri after this PR is being merged and deployed!

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks for Contributing! 🎉

@kumarsonsoff3 kumarsonsoff3 merged commit 94717c6 into EddieHubCommunity:main Mar 18, 2024
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants