-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
data :AzraNaseri #10287
data :AzraNaseri #10287
Conversation
data/AzraNaseri.json
Outdated
"social": [ | ||
{ | ||
"name": "Follow me on LinkedIn", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Socials don't require a name
key. Also there is a missing s
in "socials"
"social": [ | |
{ | |
"name": "Follow me on LinkedIn", | |
"socials": [ | |
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the codes and implemented what you mentioned. So why has it still not merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and how can i open my codes in the browser i mean to see the result (profile)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll find your profile at https://biodrop.io/AzraNaseri after this PR is being merged and deployed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Thanks for Contributing! 🎉
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers