Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Update bug.yml #9245

Conversation

Sathasivamthirumoorthi
Copy link

@Sathasivamthirumoorthi Sathasivamthirumoorthi commented Oct 1, 2023

Fixes Issue

Closes #9236

default option is removed in bug template

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

image

Note to reviewers

default is added for bug template
@github-actions github-actions bot added the CI/CD label Oct 1, 2023
Copy link
Member

@sital002 sital002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue link #9236

@@ -25,6 +25,7 @@ body:
options:
- "Yes"
- "No"
default : 0
Copy link
Member

@sital002 sital002 Oct 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default : 0
default : 1

The default option should be 1 which will default the value to No.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the example template I provided, I switched the yes and no around, so it can default to 0.

@Sathasivamthirumoorthi please use the example in the issue

@kumarsonsoff3 kumarsonsoff3 linked an issue Oct 1, 2023 that may be closed by this pull request
@kumarsonsoff3 kumarsonsoff3 added the issue linked Pull Request has issue linked label Oct 1, 2023
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution 👍

But this does not match the example in the issue and therefore is not consistent with the project

@Sathasivamthirumoorthi
Copy link
Author

I have changed default to 1

@eddiejaoude
Copy link
Member

@Sathasivamthirumoorthi can you make it the same as the other templates, the exact example was provided in the issue

@eddiejaoude
Copy link
Member

Thank you for the contribution. But closing PR because of lack of activity 2 weeks have lapsed and comments have not been addressed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI/CD issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Issue template for bug to default dropdown to "no"
4 participants