This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Feat custom domain #9436
Merged
Feat custom domain #9436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
eddiejaoude
commented
Oct 10, 2023
|
Screenshot for docs 
|
|
Domain issue... 
|
|
No Eddie that is not an issue @eddiejaoude; This also happens with hashnode: https://support.hashnode.com/en/articles/5755351-how-to-use-my-domain-on-both-vercel-and-hashnode We have to display them this table like hashnode does; I believe |
Ok, thank you 👍 great example 💯 |
|
Documentation screenshots 
|
malay44
pushed a commit
to malay44/BioDrop
that referenced
this pull request
Nov 9, 2023
* feat: use custom domain * feat: custom domain * fix: profile model domain property * feat: allow user to set custom domain * fix: efficiency improvements to middleware * fix: domain not used * fix: default value for domain * fix: deploy custom domain to preview * fix: hardcoded middleware domain * fix: debug code for middleware * fix: hostname and domain in middleware * fix: hostname replace all * fix: domain api search * fix: debugging domain api search * fix: manage premium page form * wip: add custom domain to vercel * feat: premium domain add to vercel * feat: custom domain to team + project * fix: remove custom url protocols * fix: extra custom domain check * fix: custom domain ignore www * feat: hide nav+footer if custom domain * fix: custom domain vercel error handling * docs: improve premium docs for dns * fix: extra debugging for custom domain * fix: more debugging for custom domain * fix: even more debugging for custom domain * fix: middleware rewrite condition * fix: www in custom base domain * docs: custom domain setup * feat: custom domain vercel status * fix: logging when there are errors * docs: changelog feeature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
This feature, will allow the user to set a custom domain for their Profile, for example with the custom domain
biodrop.local:3000(for local testing add to host file/etc/hosts) will display the web page fromlocalhost:3000/eddiejaoude.This is achieved by using NextJS middleware which will check Profiles in the DB for any match and return the profile on the custom domain without the appended
/eddiejaoudenote: currently thelocal issue onlyrewriterule (I left an inline comment) is super slow, commenting this out it is finetest domaintest sub domainmiddleware catch all and redirect on path for custom domain (for example:hide header/footercustom-domain/search->biodrop.io/search)search does not work due to CORS issue - not sure why this is effect by the custom domain in the middlewarebecause we usedpromote previewChanges proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers