Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data archeana #9665

Merged
merged 11 commits into from
Oct 30, 2023
Merged

data archeana #9665

merged 11 commits into from
Oct 30, 2023

Conversation

archeana
Copy link
Contributor

@archeana archeana commented Oct 29, 2023

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your file should be in data directory. Please rename it here to data/archeana.json.

Change archeana.json -> data/archeana.json

Also, make the below suggested changes!

archeana.json Outdated Show resolved Hide resolved
archeana.json Outdated
"name": "Follow me on Linkedin",
"url": "https://www.linkedin.com/in/ana-jesus-1644374a/",
"icon": "SiLinkedin"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this trailing comma here!

Suggested change
},
}

@kumarsonsoff3 kumarsonsoff3 added the ✍ chore: profile This label will be added on PR with request of Data json addition label Oct 30, 2023
@github-actions github-actions bot added the invalid Inappropriate or invalid for Hacktoberfest contributions label Oct 30, 2023
@SaraJaoude SaraJaoude dismissed kumarsonsoff3’s stale review October 30, 2023 09:18

this has now been addressed

@SaraJaoude SaraJaoude merged commit 7e262e3 into EddieHubCommunity:main Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants