Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

move premium check to middleware #9743

Merged

Conversation

dmitrykulakovfrontend
Copy link
Contributor

Fixes Issue

Closes #9630

Changes proposed

Update JWT, refactor middleware.js, remove premium checks in getServerSideProps and move them to middleware.js

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

@SaraJaoude SaraJaoude added the issue linked Pull Request has issue linked label Nov 8, 2023
middleware.js Outdated Show resolved Hide resolved
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

Looks good, I left an inline question.

Please can you also resolve conflicts

@eddiejaoude
Copy link
Member

Thank you for making the changes. Could you check your Prettier settings, it looks like extra lines are being reformatted, which makes it more difficult to review "actual" changes

@dmitrykulakovfrontend
Copy link
Contributor Author

I'm apologizing for the issue with prettier, it should be fixed now

@eddiejaoude
Copy link
Member

I'm apologizing for the issue with prettier, it should be fixed now

thank you 👍 sorry for my slow reply, I will be looking at this PR next

@eddiejaoude
Copy link
Member

I can fix the conflicts, as it has conflicted with my changes

@eddiejaoude eddiejaoude changed the base branch from main to contributions June 8, 2024 11:04
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

note: I resolved the conflicts

@eddiejaoude eddiejaoude merged commit f035911 into EddieHubCommunity:contributions Jun 8, 2024
4 of 5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Move premium user check to middleware
3 participants