-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
move premium check to middleware #9743
move premium check to middleware #9743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
Looks good, I left an inline question.
Please can you also resolve conflicts
14b4d07
to
14d7b50
Compare
Thank you for making the changes. Could you check your Prettier settings, it looks like extra lines are being reformatted, which makes it more difficult to review "actual" changes |
I'm apologizing for the issue with prettier, it should be fixed now |
thank you 👍 sorry for my slow reply, I will be looking at this PR next |
I can fix the conflicts, as it has conflicted with my changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
note: I resolved the conflicts
f035911
into
EddieHubCommunity:contributions
Fixes Issue
Closes #9630
Changes proposed
Update JWT, refactor middleware.js, remove premium checks in getServerSideProps and move them to middleware.js
Check List (Check all the applicable boxes)