-
-
Notifications
You must be signed in to change notification settings - Fork 159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
TECH: Channels regarding specific areas | ||
|
||
- **#frontend**, **#backend**, **#devops**, **#tech-other** | ||
|
||
You can raise an issue or a Pull request here https://github.com/EddieHubCommunity/support/blob/main/docs/discord/discord-readme.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I belive correct url in this line should be: https://github.com/EddieHubCommunity/support/blob/main/docs/discord/discord-readme.md
Looking at the entire file, from what I can tell there are some discord channels that are are missing in list or they to much. Which leads me to wonder, if they get unlocked at certain level for new members? |
Thanks Lea! It could be they got out of sync, could you let me know which ones you noticed are different? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed tech channels attempt looks legit to me, would approve, unless you'd like to make further changes and expand the scope of the PR itself?
@@ -64,10 +64,6 @@ TEXT CHANNELS: These consist of the server's main text channels, that are for di | |||
|
|||
- **#public-speaking**: improve your soft skills, public speaking, and build communities | |||
|
|||
TECH: Channels regarding specific areas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed tech channels attempt looks legit to me, would approve, unless you'd like to make further changes and expand the scope of the PR itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to keep PRs small if possible, so happy to merge and further changes can come in another PR
Sure thing, on it now |
@LeaDevelop if you prefer, maybe I merge this PR and you can raise a new PR? Let me know what you prefer |
I think that'd be a best flow yeah :) I set me reminder and will create issue and PR in one of the upcoming three days, heading off for today :) |
That is very well written Lea! 👍 thank you!
Thank you! I have created an issue #8671, please comment in the issue and then GitHub will let me assign it to you |
closes #ISSUE-NO
What does this PR do?
Description of the task to be completed?
How can this be manually tested?
Any background context you want to provide?
Is there any relevant issue to this PR?
Screenshots (if appropriate)
Questions