Conversion tracking for Banxa and Simplex #5368
Conversation
| @@ -1463,11 +1463,13 @@ const strings = { | |||
| fiat_plugin_fetching_assets: 'Fetching supported assets', | |||
| fiat_plugin_sell_cancelled: 'Sell order cancelled', | |||
| fiat_plugin_finalizing_quote: 'Finalizing your exchange quote. Please wait as this may take up to a minute', | |||
| fiat_plugin_buy_cancelled: 'Buy order cancelled', | |||
There was a problem hiding this comment.
Common misspelling. In American English, it's actually "canceled."
Recommend changing all these here and in the respective jsons. See transaction_details_swap_order_cancel
There was a problem hiding this comment.
There was a problem hiding this comment.
Alternatively, change transaction_details_swap_order_cancel to use two L's, since Americans don't really follow American spelling for this, anyway.
Either way, just make sure we're consistent.
|
|
||
| switch (link.query.status) { | ||
| case 'success': { | ||
| console.log('Banxa WebView launch buy success: ' + link.uri) |
There was a problem hiding this comment.
We already log tracking events, don't need to mention "buy success."
Remove completely, imo, our logging is so noisy and there's no real value to this considering we log the event immediately below.
To capture logging for the other cases, consider adding new logging events (not as conversions of course) and sync up with Peter. Adding these events would help with analytics on why/if things fail and if people are backing out of their orders for some reason.
There was a problem hiding this comment.
You didn't add new events, but that can be a separate task. Please create the task and tag Peter and I on it as collaborators.
| break | ||
| } | ||
| case 'cancelled': { | ||
| console.log('Banxa WebView launch buy cancelled: ' + link.uri) |
There was a problem hiding this comment.
If you decided to correct the "canceled" string spelling, change it here too for searchability.
|
|
||
| switch (link.query.status) { | ||
| case 'success': { | ||
| console.log('Simplex WebView launch buy success: ' + link.uri) |
samholmes
force-pushed
the
sam/track-sell-banxa-simplex
branch
from
66b6895
to
5b18a9f
Compare
| @@ -668,7 +668,7 @@ | |||
| "transaction_details_fee_warning": "High Network Fees", | |||
| "transaction_details_swap": "Swap Funds", | |||
| "transaction_details_swap_network_fee": "Swap Network Fee", | |||
| "transaction_details_swap_order_cancel": "Swap Order Canceled", | |||
There was a problem hiding this comment.
You need to replace this string in other languages that are untranslated
There was a problem hiding this comment.
What do you mean by "replace the string"?
|
|
||
| switch (link.query.status) { | ||
| case 'success': { | ||
| console.log('Banxa WebView launch buy success: ' + link.uri) |
There was a problem hiding this comment.
You didn't add new events, but that can be a separate task. Please create the task and tag Peter and I on it as collaborators.
samholmes
force-pushed
the
sam/track-sell-banxa-simplex
branch
from
3223ffa
to
89ef135
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: