-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kado OTC provider #5373
base: develop
Are you sure you want to change the base?
Add Kado OTC provider #5373
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import { View } from 'react-native' | ||
|
||
import { styled } from '../hoc/styled' | ||
|
||
export const SceneContainer = styled(View)(theme => ({ | ||
padding: theme.rem(0.5) | ||
})) | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1352,6 +1352,7 @@ | |
"form_field_title_address_line_2": "Address Line 2 (optional)", | ||
"form_field_title_address_state_province_region": "Province", | ||
"form_field_title_address_zip_postal_code": "Postal Code/Zip", | ||
"form_field_title_email_address": "Email Address", | ||
"form_field_title_iban": "IBAN", | ||
"form_field_title_swift_bic": "SWIFT/BIC", | ||
"bank_info_title": "Bank Info", | ||
|
@@ -1364,6 +1365,10 @@ | |
"bank_transfer_reference": "Reference", | ||
"sepa_form_title": "Enter Bank Info", | ||
"sepa_transfer_prompt_s": "Your order %1$s has been submitted!\n\nPlease save the order details below for your records and instruct your bank to make the payment with the information in the Payment Details section.", | ||
"otc_enter_email_to_buy": "Please enter your email to be contacted by one of our exchange partners to coordinate an OTC (Over the Counter) purchase.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These string changes belong in the next commit, not this one. |
||
"otc_enter_email_to_sell": "Please enter your email to be contacted by one of our exchange partners to coordinate an OTC (Over the Counter) sale.", | ||
"otc_confirmation_title": "Request Sent", | ||
"otc_confirmation_message": "Thank you! You will be contacted in the next 24 hours to complete your request.", | ||
"backup_account": "Back Up Account", | ||
"backup_delete_confirm_message": "Are you sure you want to delete this account without backing up first? You will NOT be able to recover wallets and transactions for this account!", | ||
"backup_info_message": "Create a username and password to create a full account and secure your funds. No personal information is required", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { useState } from 'react' | ||
|
||
import { useHandler } from '../../../hooks/useHandler' | ||
|
||
interface FieldState { | ||
onChangeText: (text: string) => void | ||
value: string | ||
} | ||
export const useFormFieldState = (defaultValue: string = ''): FieldState => { | ||
const [value, setValue] = useState<string>(defaultValue) | ||
|
||
const handleChange = useHandler(text => { | ||
setValue(text) | ||
}) | ||
Comment on lines
+12
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please remove this There is no need to wrap There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought we're suppose to use I can remove this abstraction completely though. |
||
|
||
return { | ||
onChangeText: handleChange, | ||
value | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I spot-checked some scenes, and I did notice a lot of
<View style={styles.container}>
components between theSceneWrapper
and the UI elements, so it seems like the need is real. Since this is aSceneContainer
specifically, and not aSpace
, we can tie it in with theSceneWrapper
component, such as by understanding theundoInsetStyles
or whatever (but this simple version is fine for today).I think you need to either have a sidebar with Jon, or bring this up at the Monday meeting, so we're all on board with putting this between the
SceneWrapper
and the contents. We need to get broad adoption across the codebase, so this can start making a positive impact.